Page MenuHomeFreeBSD

math/sleef: fix build on powerpc64
ClosedPublic

Authored by pkubaj on Sun, Aug 11, 10:08 AM.

Details

Summary

Altivec needs {} for vectors instead of ().
lib/libsleefgnuabi.so is not built on powerpc64.

PR: 239468

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pkubaj created this revision.Sun, Aug 11, 10:08 AM
mat added inline comments.Tue, Aug 13, 1:29 PM
math/sleef/Makefile
23 ↗(On Diff #60648)

ARCH is defined after bsd.port.options.mk, no need for the pre/post.

24 ↗(On Diff #60648)

This is badly named, it should be NO_PPC64, as it removes things on PPC64, not adds them.

pkubaj updated this revision to Diff 60741.Tue, Aug 13, 4:47 PM

Use bsd.port.options.mk and set NO_PPC64.

pkubaj marked 2 inline comments as done.Tue, Aug 13, 4:47 PM
mat accepted this revision.Mon, Aug 19, 11:55 AM
This revision is now accepted and ready to land.Mon, Aug 19, 11:55 AM
This revision was automatically updated to reflect the committed changes.