Page MenuHomeFreeBSD
Differential D21216

math/sleef: fix build on powerpc64
ClosedPublic
Actions

Authored by pkubaj on Aug 11 2019, 10:08 AM.
Tags
None
Referenced Files
F170632449: D21216.id60741.diff
Sat, Sep 5, 5:49 PM
F170632443: D21216.id60741.diff
Sat, Sep 5, 5:49 PM
F170601444: D21216.id.diff
Sat, Sep 5, 2:30 PM
F170593959: D21216.diff
Sat, Sep 5, 1:43 PM
F170572450: D21216.id61018.diff
Sat, Sep 5, 11:26 AM
F170519867: D21216.diff
Sat, Sep 5, 5:23 AM
Unknown Object (File)
Thu, Sep 3, 5:51 PM
Unknown Object (File)
Thu, Sep 3, 5:56 AM
View All Files
Subscribers
None

Details

Reviewers
linimon
mat
tcberner
Commits
rP509385: math/sleef: fix build on powerpc64
Summary

Altivec needs {} for vectors instead of ().
lib/libsleefgnuabi.so is not built on powerpc64.

PR: 239468

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

pkubaj created this revision.Aug 11 2019, 10:08 AM
Harbormaster completed remote builds in B25787: Diff 60648.Aug 11 2019, 10:08 AM
mat added inline comments.Aug 13 2019, 1:29 PM
math/sleef/Makefile
23 ↗(On Diff #60648)

ARCH is defined after bsd.port.options.mk, no need for the pre/post.

24 ↗(On Diff #60648)

This is badly named, it should be NO_PPC64, as it removes things on PPC64, not adds them.

pkubaj updated this revision to Diff 60741.Aug 13 2019, 4:47 PM

Use bsd.port.options.mk and set NO_PPC64.

Harbormaster completed remote builds in B25842: Diff 60741.Aug 13 2019, 4:47 PM
pkubaj marked 2 inline comments as done.Aug 13 2019, 4:47 PM
mat accepted this revision.Aug 19 2019, 11:55 AM
This revision is now accepted and ready to land.Aug 19 2019, 11:55 AM
Closed by commit rP509385: math/sleef: fix build on powerpc64 (authored by pkubaj). · Explain WhyAug 19 2019, 11:33 PM
This revision was automatically updated to reflect the committed changes.
pkubaj added a commit: rP509385: math/sleef: fix build on powerpc64.

Revision Contents
Changeset List

PathSize
head/
math/
sleef/
8 lines
files/
14 lines
6 lines

Diff 61018

View Options

head/math/sleef/Makefile

Loading...
View Options

head/math/sleef/files/patch-src_libm-tester_tester3.c

Loading...
View Options

head/math/sleef/pkg-plist

Loading...