Page MenuHomeFreeBSD

net-mgmt/netbox: Add sample rc script
Needs ReviewPublic

Authored by kai on Aug 2 2019, 6:08 PM.

Details

Reviewers
matthew
miwi
pi
Summary
  • Add a sample rc script (courtesy by Thomas Kurschel) that only requires www/py-gunicorn to run via the EXAMPLES option.
  • It's a more lightweight variant and doesn't require sysutils/py-supervisor to run.
Test Plan
  • poudriere -> OK
  • Script has been tested several weeks in production -> OK

The script is not added via USE_RC_SUBR to avoid additional dependencies on www/py-gunicorn and the goal in mind to let the user choose which solution (rc script, sysutils/py-supervisor, etc.) suits best for their needs.

Another variant that comes into mind would be to add a non-default option, e.g. GUNICORN, which installs then the rc script and www/py-gunicorn. I'm also open for adding the script via USE_RC_SUBR if this makes more sense.

What do you think about it?

Diff Detail

Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25700
Build 24285: arc lint + arc unit

Event Timeline

kai created this revision.Aug 2 2019, 6:08 PM

Add some OPTIONS to allow the user to choose between different WSGI servers? Similarly to how eg. www/rt44 allows choosing between several different ways of running a perl-based web application.

kai updated this revision to Diff 60499.Aug 6 2019, 9:37 AM

Changed the EXAMPLES option to a non-default option GUNICORN. If users enable that option it installs the Gunicorn WSGI, the contributed script and the required user/group.

kai added a comment.Aug 6 2019, 9:42 AM

Add some OPTIONS to allow the user to choose between different WSGI servers? Similarly to how eg. www/rt44 allows choosing between several different ways of running a perl-based web application.

Thank you for the pointer to www/rt44. I can introduce some more WSGI servers but I haven't tested other alternatives than Gunicorn, yet. If you already used an other WSGI server than Gunicorn together with NetBox in test/production environment I'll be happy to add it as an additional option.