Differential D2113

Fix double settings of vars due to being done before bsd.port.post.mk.
ClosedPublic
Actions

Authored by bdrewery on Mar 22 2015, 8:17 PM.

Details

Reviewers

bapt

Group Reviewers

portmgr

Summary

Fix duplicate values in ENV vars and X_BUILD_FOR truncating BUILD_DEPENDS.

PKG_NOTES/PKG_ENV/CONFIGURE_ENV/MAKE_ENV/CO_ENV/QA_ENV were using += before the
double include check so any port using bsd.port.options.mk or bsd.port.pre.mk
would have duplicated items in these vars.

All ports would have their BUILD_DEPENDS truncated with X_BUILD_FOR.

Test Plan

Local make -V testing with bsd.port.pre.mk / bsd.port.options.mk and setting X_BUILD_FOR. Local poudriere testing.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bdrewery updated this revision to Diff 4334.Mar 22 2015, 8:17 PM

bdrewery retitled this revision from to Fix double settings of vars due to being done before bsd.post.port.mk..

bdrewery updated this object.

bdrewery edited the test plan for this revision. (Show Details)

bdrewery added a reviewer: portmgr.

Herald edited edge metadata. · View Herald TranscriptMar 22 2015, 8:17 PM

bdrewery retitled this revision from Fix double settings of vars due to being done before bsd.post.port.mk. to Fix double settings of vars due to being done before bsd.port.post.mk..Mar 22 2015, 8:18 PM

bdrewery edited the test plan for this revision. (Show Details)

bdrewery edited edge metadata.