devel/crc32c: fix build on big-endian architectures
ClosedPublic
Actions

Authored by pkubaj on Jul 24 2019, 1:38 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Mar 1, 8:24 PM

	Unknown Object (File)
	Mon, Feb 24, 1:47 AM

	Unknown Object (File)
	Sun, Feb 23, 7:16 PM

	Unknown Object (File)
	Sun, Feb 23, 6:41 PM

	Unknown Object (File)
	Sun, Feb 23, 6:42 AM

	Unknown Object (File)
	Sun, Feb 23, 5:48 AM

	Unknown Object (File)
	Sat, Feb 22, 9:34 AM

	Unknown Object (File)
	Sat, Feb 22, 2:08 AM

View All 50 Files

Subscribers

None

Details

Reviewers

linimon
mat
tcberner

Commits

rP507823: devel/crc32c: fix build on big-endian architectures

Summary

C++11 compiler is needed:

Target "crc32c" requires the language dialect "CXX11" , but CMake does not
know the compile flags to use to enable it.

Additionally, big-endian code in src/crc32c_read_le.h needs fixing - the value is 64 bits wide, not 32 bits.

PR: 239420

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pkubaj created this revision.Jul 24 2019, 1:38 PM

Harbormaster completed remote builds in B25492: Diff 60089.Jul 24 2019, 1:38 PM

linimon accepted this revision.Aug 1 2019, 12:41 AM

This revision is now accepted and ready to land.Aug 1 2019, 12:41 AM

Closed by commit rP507823: devel/crc32c: fix build on big-endian architectures (authored by pkubaj). · Explain WhyAug 1 2019, 7:12 PM

This revision was automatically updated to reflect the committed changes.

pkubaj added a commit: rP507823: devel/crc32c: fix build on big-endian architectures.

Revision Contents
Changeset List

Path

Size

head/

devel/

crc32c/

Makefile

2 lines

files/

patch-src_crc32c__read__le.h

25 lines

Diff 60368

View Options

head/devel/crc32c/Makefile

View Options

head/devel/crc32c/files/patch-src_crc32creadle.h

devel/crc32c: fix build on big-endian architecturesClosedPublicActions