Page MenuHomeFreeBSD
Differential D20984

graphics/png: Use CMake, add debug, optimization and test options
AbandonedPublic
Actions

Authored by antoine on Jul 18 2019, 11:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 16, 3:53 AM
Unknown Object (File)
Tue, Sep 30, 6:49 PM
Unknown Object (File)
Sat, Sep 27, 7:04 PM
Unknown Object (File)
Sat, Sep 27, 7:19 AM
Unknown Object (File)
Sep 15 2025, 11:33 AM
Unknown Object (File)
Aug 26 2025, 9:27 PM
Unknown Object (File)
Aug 26 2025, 5:37 PM
Unknown Object (File)
Aug 26 2025, 1:52 PM
View All 26 Files
Subscribers
antoine
mat

Details

Reviewers
diizzy
Group Reviewers
portmgr
Summary

Convert to CMake
Add options for debug, optimization and test
Switch apng patch repo to libpng-apng, same as Mozilla, Debian (Unbuntu etc), Arch and Alpine Linux to mention a few.

Patch submitted upstream: https://github.com/glennrp/libpng/pull/311

Test Plan

Tested on AMD64
Will test on ARM64 within few days

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

diizzy created this revision.Jul 18 2019, 11:13 AM
Herald added a subscriber: mat. · View Herald TranscriptJul 18 2019, 11:13 AM
diizzy edited the test plan for this revision. (Show Details)Jul 18 2019, 11:19 AM
diizzy added inline comments.Jul 18 2019, 11:37 AM
graphics/png/Makefile
6

I'll submit a new patch for missing empty line

antoine added a subscriber: antoine.Jul 18 2019, 12:17 PM

Why?
It works perfectly without cmake and doesn't need any patching.

antoine commandeered this revision.Jul 18 2019, 12:19 PM
antoine abandoned this revision.
antoine added a reviewer: diizzy.

Rejected.

Revision Contents
Changeset List

PathSize
graphics/
png/
18 lines
6 lines
files/
44 lines
2 lines

Diff 59876

View Options

graphics/png/Makefile

Loading...
View Options

graphics/png/distinfo

Loading...
View Options

graphics/png/files/patch-CMakeLists.txt

Loading...
View Options

graphics/png/pkg-plist

Loading...