Page MenuHomeFreeBSD

www/nginx: Add forked version of nginx-rtmp-module by Raphael Mazelier (ut0mt8)
ClosedPublic

Authored by daniel.engberg.lists_pyret.net on Jul 4 2019, 12:01 PM.

Details

Summary

Add forked version of nginx-rtmp-module which includes a few bugs fixes and enhancements such as adaptive streaming and common-encryption (DRM).
See https://github.com/ut0mt8/nginx-rtmp-module for more information

Test Plan

Compiled and runtime tested on -CURRENT (AMD64)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Update PORTREVISION instead of PORTEPOCH

Thanks for your review.
But I don't see any point in adding an additional rtpm version.
If the current version contains bugs, please open a request on GH.

As far as I can tell it's more or less abandoned by the original author https://github.com/arut/nginx-rtmp-module/pulls (several PRs are very old by now) no commits since late 2017 https://github.com/arut/nginx-rtmp-module/commits/master
This plugin was then forked and "maintained"/enhanced by Sergey Dryabzhinsky https://github.com/sergey-dryabzhinsky/nginx-rtmp-module/ and then forked again and futher enhanced by Raphael Mazelier who has submitted a PR to upstream back in 2018 (https://github.com/sergey-dryabzhinsky/nginx-rtmp-module/pull/276)

Another option would be replacing the "old" (current) one.

Should I replace the current module? I'd like this to move forward in some direction.

When i look here: https://github.com/ut0mt8/nginx-rtmp-module/commits/dev - Last commit 8. Dec 2018
And here: https://github.com/sergey-dryabzhinsky/nginx-rtmp-module/commits/dev - Last commit 4. May 2019

So I think a change to "sergey-dryabzhinsky" makes sense

If you look at the commit log last commit (that's not text related) it occurred on on Mar 30, 2018 in sergey-dryabzhinsky's tree. If you look at ut0mt8's repo there's a lot of work done after that date.

Hi,
How do you want to proceed?

Sorry for the late reply but I finally got around with a Poudriere setup and I can't reproduce your failure using this patch

http://projects.pyret.net/files/public/freebsd/nginx-rtmp-ut0mt8.patch
http://projects.pyret.net/files/public/freebsd/nginx-rtmp-ut0mt8-poudriere.log

This revision was not accepted when it landed; it landed in state Needs Review.Sep 10 2019, 8:42 AM
This revision was automatically updated to reflect the committed changes.

As the author of the fork (ut0mt8) I can say that yes my fork is way ahead in term of functionalities that the sergey one. I tried to re-upstream all my changes either to sergey one or to upstream without luck.
What I tried is to backport bugfixes from sergey to my repo, but I lack time to do this regularly. Apart this my fork only add functionalities that are off by default, without breaking the other logic (I hope :) ).