Add forked version of nginx-rtmp-module which includes a few bugs fixes and enhancements such as adaptive streaming and common-encryption (DRM).
See https://github.com/ut0mt8/nginx-rtmp-module for more information
Details
- Reviewers
joneum - Commits
- rP511749: Switch the rtmp module to ut0mt8.
Compiled and runtime tested on -CURRENT (AMD64)
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Thanks for your review.
But I don't see any point in adding an additional rtpm version.
If the current version contains bugs, please open a request on GH.
As far as I can tell it's more or less abandoned by the original author https://github.com/arut/nginx-rtmp-module/pulls (several PRs are very old by now) no commits since late 2017 https://github.com/arut/nginx-rtmp-module/commits/master
This plugin was then forked and "maintained"/enhanced by Sergey Dryabzhinsky https://github.com/sergey-dryabzhinsky/nginx-rtmp-module/ and then forked again and futher enhanced by Raphael Mazelier who has submitted a PR to upstream back in 2018 (https://github.com/sergey-dryabzhinsky/nginx-rtmp-module/pull/276)
Another option would be replacing the "old" (current) one.
Should I replace the current module? I'd like this to move forward in some direction.
When i look here: https://github.com/ut0mt8/nginx-rtmp-module/commits/dev - Last commit 8. Dec 2018
And here: https://github.com/sergey-dryabzhinsky/nginx-rtmp-module/commits/dev - Last commit 4. May 2019
So I think a change to "sergey-dryabzhinsky" makes sense
If you look at the commit log last commit (that's not text related) it occurred on on Mar 30, 2018 in sergey-dryabzhinsky's tree. If you look at ut0mt8's repo there's a lot of work done after that date.
I will tested later. Currently i will switch the module: http://joneum.joneumbox.org/nginx-rtmp.diff
But pkg-plist has a problem:http://joneumbox.org/data/112amd64-ports/2019-08-26_10h31m22s/logs/errors/nginx-1.16.1_2,2.log
Sorry for the late reply but I finally got around with a Poudriere setup and I can't reproduce your failure using this patch
http://projects.pyret.net/files/public/freebsd/nginx-rtmp-ut0mt8.patch
http://projects.pyret.net/files/public/freebsd/nginx-rtmp-ut0mt8-poudriere.log
As the author of the fork (ut0mt8) I can say that yes my fork is way ahead in term of functionalities that the sergey one. I tried to re-upstream all my changes either to sergey one or to upstream without luck.
What I tried is to backport bugfixes from sergey to my repo, but I lack time to do this regularly. Apart this my fork only add functionalities that are off by default, without breaking the other logic (I hope :) ).