Page MenuHomeFreeBSD

sysutils/minipro: fix build with GCC-based architectures
ClosedPublic

Authored by pkubaj on Jul 1 2019, 11:32 AM.

Details

Summary

This port needs new GCC to build on GCC architectures.

Actually respect CC by not replacing it with clang, instead remove it to use CC passed from ports.

Also respect CFLAGS.

PR: 238515

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Jul 1 2019, 7:19 PM
sysutils/minipro/Makefile
27–29 ↗(On Diff #59251)

Put the changes to a separate patch and remove post-patch target.

Also, don't remove CC=gcc, but set CC?=gcc instead.

This revision now requires review to proceed.Jul 1 2019, 7:58 PM
sysutils/minipro/files/patch-Makefile
13 ↗(On Diff #59282)

Should be ?= this appends the existing CFLAGS, thus not respecting what the user want. Say they want -O3, now the Makefile here adds -O0 disabling -O3.

I can confirm that with the new patch, the port does build on powerpc64.

This revision is now accepted and ready to land.Jul 8 2019, 2:44 PM