Page MenuHomeFreeBSD

editors/xi-core: Update to latest snapshot
ClosedPublic

Authored by kai on May 4 2019, 9:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 25 2024, 11:32 PM
Unknown Object (File)
Oct 25 2024, 11:32 PM
Unknown Object (File)
Oct 25 2024, 11:32 PM
Unknown Object (File)
Oct 25 2024, 11:32 PM
Unknown Object (File)
Oct 25 2024, 11:18 PM
Unknown Object (File)
Oct 1 2024, 2:49 PM
Unknown Object (File)
Oct 1 2024, 1:29 PM
Unknown Object (File)
Oct 1 2024, 8:08 AM
Subscribers

Details

Summary
  • The project moved to a new repository
  • Update port to latest snapshot
  • Add DOCS option
  • Update WWW field
  • Submitter adopts the port

PR: 237532
Submitted by: Nuno Teixeira

Test Plan
  • poudriere (11.2-, 12.0-RELEASE, 13.0-CURRENT@r346346 amd64 + i386) -> OK
  • portlint -> OK
  • Runtime tests -> OK (the port starts but is not usable in its standalone form because a frontend is required for it, e.g. editors/xi-term)

Minor fixes from the original patch:

  • Removed OPTIONS_DEFAULT=DOCS as the DOCS is enabled by default
  • Rearranged GH_TUPLE and CARGO_USE_GITHUB to make future updates/commits somewhat easier

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24108
Build 22968: arc lint + arc unit

Event Timeline

tobik requested changes to this revision.May 4 2019, 10:24 PM
tobik added a subscriber: tobik.

Rearranged GH_TUPLE and CARGO_USE_GITHUB to make future updates/commits somewhat easier

I do not see how the current arrangement is easier. make cargo-crates outputs things in the following order:

GH_TUPLE=	...
CARGO_CRATES=		...
CARGO_USE_GITHUB=	yes

Since you mostly want to paste its output into the Makefile you should preferably retain that order unless you want to always move CARGO_USE_GITHUB around on updates.

editors/xi-core/Makefile
180

${INSTALL_MAN} ${WRKSRC:H}/README.md ${STAGEDIR}${DOCSDIR}

Documentation should be installed with ${INSTALL_MAN} per the Porter's Handbook [1].

[1] https://www.freebsd.org/doc/en/books/porters-handbook/install.html

This revision now requires changes to proceed.May 4 2019, 10:24 PM
  • Rerranged GH_TUPLE, CARGO_CRATES, CARGO_USE_GITHUB
  • s/${INSTALL_DATA}/${INSTALL_MAN}/
This revision is now accepted and ready to land.May 4 2019, 10:39 PM

Thank you @tobik for your pointers and the quick review!

This revision was automatically updated to reflect the committed changes.