Differential D20155

db, various cleanups
ClosedPublic
Actions

Authored by pkubaj on May 4 2019, 11:09 AM.

Details

Reviewers

linimon
tcberner
mat

Commits

rP503924: mail/dcc-dccd: update to 2.3.164, use /var/db/dcc instead of /var/db, various…

Summary

Contains fixes from https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220978

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pkubaj created this revision.May 4 2019, 11:09 AM

Harbormaster completed remote builds in B24097: Diff 57032.May 4 2019, 11:09 AM

Is there some user interaction required after the update due to the directory move? If so, you should probably document that in UPDATING.

mat added inline comments.May 14 2019, 11:15 AM

mail/dcc-dccd/Makefile
8 ↗	(On Diff #57032)	I'm quite sure you did not put the new version of the port here, so you can safely remove this.
14–19 ↗	(On Diff #57032)	So, the license says we cannot distribute package or sell them, but only if we're not actually distributing packages. It feels strange, and the .if should probably be removed. Or at least, the license should be checked.

Correct according to comments.

No UPDATING entry is necessary, configs will not be moved.

Harbormaster completed remote builds in B24298: Diff 57520.May 18 2019, 3:54 AM

pkubaj marked 2 inline comments as done.May 18 2019, 3:54 AM

mat accepted this revision.May 20 2019, 1:12 PM

This revision is now accepted and ready to land.May 20 2019, 1:12 PM

Since I have not committed this yet and there's a new release, update to it.

This revision now requires review to proceed.May 24 2019, 8:01 AM

Harbormaster completed remote builds in B24469: Diff 57834.May 24 2019, 8:01 AM

pkubaj retitled this revision from mail/dcc-dccd: update to 1.3.163, use /var/db/dcc instead of /var/db, various cleanups to mail/dcc-dccd: update to 2.3.164, use /var/db/dcc instead of /var/db, various cleanups.May 24 2019, 8:02 AM

mat accepted this revision.Jun 8 2019, 5:08 PM

This revision is now accepted and ready to land.Jun 8 2019, 5:08 PM

Closed by commit rP503924: mail/dcc-dccd: update to 2.3.164, use /var/db/dcc instead of /var/db, various… (authored by pkubaj). · Explain WhyJun 10 2019, 8:05 PM

This revision was automatically updated to reflect the committed changes.