Page MenuHomeFreeBSD
Differential D19994

audio/vgmplay: correct endianness on big-endian architectures
ClosedPublic
Actions

Authored by pkubaj on Apr 20 2019, 9:36 PM.
Tags
None
Referenced Files
F154444898: D19994.id56853.diff
Tue, Apr 28, 2:50 PM
Unknown Object (File)
Sun, Apr 26, 2:04 AM
Unknown Object (File)
Tue, Apr 21, 12:30 PM
Unknown Object (File)
Tue, Apr 21, 5:42 AM
Unknown Object (File)
Tue, Apr 21, 5:07 AM
Unknown Object (File)
Tue, Apr 21, 5:07 AM
Unknown Object (File)
Tue, Apr 21, 3:46 AM
Unknown Object (File)
Mon, Apr 20, 5:34 PM
View All Files
Subscribers
None

Details

Reviewers
tcberner
mat
linimon
Commits
rP500834: audio/vgmplay: correct endianness on big-endian architectures
Summary

By default little-endian is specified, which may result in runtime issues. Set it to big-endian where needed.

Also add USES=localbase:ldflags.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237173

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

pkubaj created this revision.Apr 20 2019, 9:36 PM
Harbormaster completed remote builds in B23794: Diff 56442.Apr 20 2019, 9:36 PM
mat added a comment.Apr 30 2019, 1:44 PM

Shouldn't this also include a PORTREVISION bump to fix runtime issues?

pkubaj updated this revision to Diff 56853.Apr 30 2019, 2:05 PM

Bump PORTREVISION.

Harbormaster completed remote builds in B24006: Diff 56853.Apr 30 2019, 2:06 PM
tcberner accepted this revision.May 4 2019, 9:39 AM
This revision is now accepted and ready to land.May 4 2019, 9:39 AM
Closed by commit rP500834: audio/vgmplay: correct endianness on big-endian architectures (authored by pkubaj). · Explain WhyMay 4 2019, 10:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
audio/
vgmplay/
9 lines

Diff 57051

View Options

head/audio/vgmplay/Makefile

Loading...