Page MenuHomeFreeBSD

[NEW PORT] games/fs2open: FreeSpace 2 video engine
ClosedPublic

Authored by pkubaj on Apr 18 2019, 10:42 AM.

Details

Summary

New port with FreeSpace 2 video engine. To play it you need original game data.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229321

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pkubaj created this revision.Apr 18 2019, 10:42 AM
mat added inline comments.Apr 18 2019, 1:04 PM
games/fs2open/Makefile
13–16 ↗(On Diff #56330)

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

22 ↗(On Diff #56330)
DISTVERSIONPREFIX=  release_
DISTVERSION=        3_8_0
games/fs2open/pkg-descr
1 ↗(On Diff #56330)

pkg-descr should contain a paragraph of at least two lines.

pkubaj updated this revision to Diff 56887.Apr 30 2019, 7:55 PM

Correct according to comments.

mat added inline comments.May 1 2019, 7:11 AM
games/fs2open/Makefile
13–14 ↗(On Diff #56887)

Those two lines should be reversed, see Chapter 15. Order of Variables in Port Makefiles.

games/fs2open/files/pkg-message.in
1–2 ↗(On Diff #56887)

This file has absolutely no replacements, so it does not need to sed'ed.

Putting it in the ports's directory, and naming it pkg-message is enough.

pkubaj updated this revision to Diff 56922.May 1 2019, 6:18 PM

Correct according to comments.

mat added inline comments.May 2 2019, 7:47 AM
games/fs2open/Makefile
28 ↗(On Diff #56922)

Have you test-built this version? Because this line should now give you an error.

linimon added inline comments.May 2 2019, 5:56 PM
games/fs2open/Makefile
28 ↗(On Diff #56922)

portlint agrees that this line should go away.

games/fs2open/distinfo
2 ↗(On Diff #56922)

SHA256 (scp-fs2open-fs2open.github.com-release_3_8_0_GH0.tar.gz) = c932d86daa2fe3dedf533a8904ed0cc9916bfe8ccf8e1cffcc20911a88d36457

(portlint says that they do not match, otherwise)

3 ↗(On Diff #56922)

SIZE (scp-fs2open-fs2open.github.com-release_3_8_0_GH0.tar.gz) = 8711455

(portlint says that they do not match, otherwise)

games/fs2open/pkg-descr
1 ↗(On Diff #56330)

portlint complains about the long lines. I pacified it somewhat by adding linebreaks around position 70, but then it complained about > 24 lines. I think the linebreaks should be done and the latter complaint ignored.

mat added inline comments.May 2 2019, 8:23 PM
games/fs2open/Makefile
28 ↗(On Diff #56922)

I'm not talking about portlint, I'm talking about actually building the port.

games/fs2open/distinfo
2 ↗(On Diff #56922)

Building the port would also catch this.

3 ↗(On Diff #56922)

Building the port would also catch this.

linimon added inline comments.May 3 2019, 1:14 AM
games/fs2open/Makefile
28 ↗(On Diff #56922)

Your workflow varies from mine. I run portlint before build.

pkubaj updated this revision to Diff 57064.May 5 2019, 1:13 PM
pkubaj marked 8 inline comments as done.

Tested to build on 11.2/amd64 with Poudriere.

pkg-descr was shortened.

Portlint says looks fine.

tcberner added inline comments.May 12 2019, 10:46 AM
games/fs2open/files/patch-cmake_toolchain-clang.cmake
8 ↗(On Diff #57064)

^ why is this needed?

pkubaj added inline comments.May 12 2019, 10:49 AM
games/fs2open/files/patch-cmake_toolchain-clang.cmake
8 ↗(On Diff #57064)

It's not, but my understanding is that we should remove -O* flags from ports.

This revision is now accepted and ready to land.May 12 2019, 10:55 AM
This revision was automatically updated to reflect the committed changes.