Page MenuHomeFreeBSD
Differential D19820

devel/jech-dht: Update to 0.26.
ClosedPublic
Actions

Authored by rigoletto on Apr 4 2019, 4:30 PM.
Tags
None
Referenced Files
F175788629: D19820.id55811.diff
Tue, Oct 13, 9:11 AM
F175788547: D19820.id55830.diff
Tue, Oct 13, 9:11 AM
F175788421: D19820.id55804.diff
Tue, Oct 13, 9:09 AM
F175788400: D19820.id55810.diff
Tue, Oct 13, 9:09 AM
F175766672: D19820.diff
Tue, Oct 13, 4:35 AM
Unknown Object (File)
Sun, Oct 11, 5:40 PM
Unknown Object (File)
Wed, Sep 30, 6:11 PM
Unknown Object (File)
Mon, Sep 28, 8:03 PM
View All Files
Subscribers
None

Details

Reviewers
mat
tcberner
Commits
rP497937: devel/jech-dht: Update to 0.26.
Summary

PR 234515

  • update to 0.26
  • take maintainership as arranged with the current maintainer.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rigoletto created this revision.Apr 4 2019, 4:30 PM
Harbormaster completed remote builds in B23513: Diff 55804.Apr 4 2019, 4:30 PM
tcberner added inline comments.Apr 4 2019, 5:56 PM
devel/jech-dht/Makefile
19 ↗(On Diff #55804)

^ why did you change to inline plist?

rigoletto added inline comments.Apr 4 2019, 6:06 PM
devel/jech-dht/Makefile
19 ↗(On Diff #55804)

Too few files and to shut portlint .

tcberner added inline comments.Apr 4 2019, 6:16 PM
devel/jech-dht/Makefile
19 ↗(On Diff #55804)

I would keep it in the plist -- to reduce the churn. Porlint isn't a law :)

rigoletto updated this revision to Diff 55810.Apr 4 2019, 6:46 PM
rigoletto marked 2 inline comments as done.

Bring pkg-plist back.

Harbormaster completed remote builds in B23518: Diff 55810.Apr 4 2019, 6:46 PM
rigoletto updated this revision to Diff 55811.Apr 4 2019, 6:48 PM

Now yes, bring pkg-plist back.

Harbormaster completed remote builds in B23519: Diff 55811.Apr 4 2019, 6:48 PM
tcberner accepted this revision.Apr 5 2019, 5:02 AM
This revision is now accepted and ready to land.Apr 5 2019, 5:02 AM
mat added inline comments.Apr 5 2019, 6:02 AM
devel/jech-dht/Makefile
17 ↗(On Diff #55811)

Why +=?

24 ↗(On Diff #55811)

You cannot write to STAGEDIR before the install phase.

Closed by commit rP497937: devel/jech-dht: Update to 0.26. (authored by rigoletto). · Explain WhyApr 5 2019, 6:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
devel/
jech-dht/
15 lines
6 lines
files/
2 lines
109 lines

Diff 55830

View Options

head/devel/jech-dht/Makefile

Loading...
View Options

head/devel/jech-dht/distinfo

Loading...
View Options

head/devel/jech-dht/files/BSDmakefile

Loading...
View Options

head/devel/jech-dht/files/patch-warns

Loading...