Page MenuHomeFreeBSD

sysutils/rubygem-bundler117: Repocopied from sysutils/rubygem-bundler
ClosedPublic

Authored by meta on Apr 4 2019, 9:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 7:24 AM
Unknown Object (File)
Fri, May 3, 7:24 AM
Unknown Object (File)
Fri, May 3, 7:24 AM
Unknown Object (File)
Fri, May 3, 7:24 AM
Unknown Object (File)
Fri, May 3, 7:23 AM
Unknown Object (File)
Fri, May 3, 5:08 AM
Unknown Object (File)
Apr 4 2024, 5:50 PM
Unknown Object (File)
Apr 4 2024, 5:49 PM
Subscribers
None

Details

Summary

Updating systils/rubygem-bundler to 2.0.1 breaks some consumers.
Keep the older version in ports tree and some consumers should refer the older version.

I'm going to update consumer's dependency in this changeset.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Add SUBDIR to sysutils/Makefile

meta added a reviewer: mfechner.
sysutils/Makefile
1124 ↗(On Diff #55799)

I would not fix it to version 117 but better to version 1, so name the port better rubygem-bundler1

sysutils/rubygem-bundler117/Makefile
8 ↗(On Diff #55799)

Same we comment above.

24 ↗(On Diff #55799)

Have you tested this?
There is a high risk that new binary names will break existing installation as they will use bin/bundler and not bin/bundler117 (here you maybe want also to use bundler1 as most port should have dependency ~> 1.17

You maybe also would like to add a PORTSCOUT line.

sysutils/Makefile
1124 ↗(On Diff #55799)

I looked at ports tree history and there was rubygem-budler17 for bundler 1.7 series. So I follow the past way. However, rubygem-bundler1 sounds better.

sysutils/rubygem-bundler117/Makefile
24 ↗(On Diff #55799)

Not yet. Looking at past rubygem-bundler17 for bundler 1.7, it doesn't install bundler execurables.
https://github.com/freebsd/freebsd-ports/blob/402b279db75bb6b490f4ad23d75b40aa79c1bf0e/sysutils/rubygem-bundler17/Makefile#L21

Maybe it would not be a problem. I think new executable names are better rather than not installing executables so I renamed. Of course I need to test it, though.

Rename to rubygem-bundler1

Set PORTEPOCH to 0. It can be reset if a port name changed.

This revision is now accepted and ready to land.Apr 5 2019, 9:17 AM
sysutils/rubygem-bundler117/Makefile
24 ↗(On Diff #55799)

For the record, devel/gitaly needs to be patched to use bin/bundle1.

I think that r498360 should fix the problem for bundler version 2 (not tested).

This revision was automatically updated to reflect the committed changes.