Page MenuHomeFreeBSD

freebsd32: fix padding of computed control message length for recvmsg()
ClosedPublic

Authored by jah on Mar 30 2019, 11:21 PM.

Details

Summary

Each control message region must be aligned on a 4-byte boundary on 32-bit
architectures. The 32-bit compat shim for recvmsg() gets the actual layout
right, but doesn't pad the payload length when computing msg_controllen for
the output message header. If a control message contains an unaligned
payload, such as the 1-byte TTL field in the example attached to PR 236737,
this can produce control message payload boundaries that extend beyond
the boundary reported by msg_controllen.

PR: 236737

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jah created this revision.Mar 30 2019, 11:21 PM
jah added a reviewer: markj.Mar 30 2019, 11:22 PM
markj accepted this revision.Mar 30 2019, 11:35 PM
This revision is now accepted and ready to land.Mar 30 2019, 11:35 PM
This revision was automatically updated to reflect the committed changes.