Page MenuHomeFreeBSD

sysutils/zol-kmod: clean up
AcceptedPublic

Authored by jbeich on Mar 25 2019, 7:25 PM.

Details

Reviewers
kmoore
Summary
  • Switch to vendor make targets
  • Embed real Git revision
  • Add license file (for LICENSES_ASK=1 mode)
  • Avoid repetition in GCOV_DESC
  • Convert to option helpers
  • Other minor style
Test Plan

Runtime appears to work fine but I've only tested my ZFS-only setup for a few minutes.

poudriere bulk -t reports:

  • builds fine on 13.0 amd64 and aarch64
  • builds fine with DEBUG=on or GCOV=on

Diff Detail

Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23292
Build 22324: arc lint + arc unit

Event Timeline

@rene, how does USES=kmod:debug work given Mk/bsd.port.mk defines MK_KERNEL_SYMBOLS=no? I'd like to get rid of do-install-DEBUG-on here but the documentation is confusing.

Looks pretty good here. I'm fine with a merge once you get an answer on USES=kmod:debug.

Thank you so much for the cleanup on this port!

This revision is now accepted and ready to land.Mar 25 2019, 8:46 PM