Page MenuHomeFreeBSD

[NEW PORT] archivers/php-brotli: PHP Extension for Brotli
ClosedPublic

Authored by daniel_shafer.cc on Mar 18 2019, 12:03 AM.

Details

Summary
[NEW PORT] archivers/php-brotli: PHP Extension for Brotli

Brotli is a generic-purpose lossless compression algorithm that compresses
data using a combination of a modern variant of the LZ77 algorithm, Huffman
coding and 2nd order context modeling, with a compression ratio comparable
to the best currently available general-purpose compression methods. It is
similar in speed with deflate but offers more dense compression.

This is the Brotli Extension for PHP

WWW: https://github.com/kjdev/php-ext-brotli

PR: 236610
Submitted by: Daniel Shafer <daniel@shafer.cc>
Differential_Revision: D19619

This is version 0.6.2 released on January 6th, 2019.

Test Plan
  • portlint: looks okay.
  • testport: OK (poudriere: 12amd64 tested)
  • maketest: NA

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23167
Build 22215: arc lint + arc unit

Event Timeline

daniel_shafer.cc edited the summary of this revision. (Show Details)Mar 18 2019, 12:04 AM
tcberner added inline comments.Mar 18 2019, 5:12 AM
archivers/php-brotli/Makefile
23

^ why does it need brotli sources again? -- brotli should be available from the libdepends, right?

mat added inline comments.Mar 18 2019, 1:17 PM
archivers/php-brotli/Makefile
13

${WRKSRC_brotli}

23

Also, it is not referenced anywhere here except for the LICENSE. If it is only for the license file, it probably is not worth it.

So mat and tcberner were correct, brotli sources are only needed if not
building against source. Since we are building with --with-libbrotli
we are using the system libraries and don't need the source.

Forgot to update distinfo, corrected.

tcberner accepted this revision.Mar 18 2019, 8:36 PM

lgtm, and committed.

This revision is now accepted and ready to land.Mar 18 2019, 8:36 PM
tcberner closed this revision.Mar 18 2019, 8:38 PM