Page MenuHomeFreeBSD
Differential D1954

Drop Ruby 1.9 support
ClosedPublic
Actions

Authored by rene on Feb 23 2015, 10:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 25, 6:54 AM
Unknown Object (File)
Dec 11 2024, 3:25 PM
Unknown Object (File)
Dec 11 2024, 3:24 PM
Unknown Object (File)
Dec 11 2024, 3:23 PM
Unknown Object (File)
Dec 11 2024, 3:22 PM
Unknown Object (File)
Dec 11 2024, 3:16 PM
Unknown Object (File)
Dec 11 2024, 3:12 PM
Unknown Object (File)
Nov 22 2024, 11:55 PM
View All Files
Subscribers
sunpoet
swills

Details

Reviewers
swills
sunpoet
Group Reviewers
Ruby
Summary

Ruby 1.9 expired on 2015-02-23, drop support from the Ports Tree:

  • prune Ruby 1.9 from Mk/bsd.ruby.mk
  • remove lang/ruby19
Test Plan

make index
Maybe a (mini) exp-run?

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

rene updated this revision to Diff 3933.Feb 23 2015, 10:22 PM
rene retitled this revision from to Drop Ruby 1.9 support.
rene updated this object.
rene edited the test plan for this revision. (Show Details)
rene added a reviewer: Ruby.
rene set the repository for this revision to rP FreeBSD ports repository.
swills accepted this revision.Feb 24 2015, 3:01 PM
swills added a reviewer: swills.
swills added a subscriber: swills.

Yep, that was my plan, don't forget to kill lang/ruby19 (remove from lang/Makefile too).

This revision is now accepted and ready to land.Feb 24 2015, 3:01 PM
swills added a comment.Feb 24 2015, 3:05 PM

Oh, and an UPDATING entry would be good.

swills added a comment.Feb 24 2015, 3:06 PM

Also forgot to say, exp-run not needed. 2.0 is default.

sunpoet added a subscriber: sunpoet.Feb 24 2015, 5:30 PM
sunpoet added a reviewer: sunpoet.Feb 24 2015, 5:34 PM

FYI, there are 2 more lines can be removed.

Mk/bsd.ruby.mk
212–213

This can be removed.

343–344

This can be removed.

rene updated this revision to Diff 3957.Feb 24 2015, 6:54 PM
rene edited edge metadata.

Incorporated sunpoets suggestions.

This revision now requires review to proceed.Feb 24 2015, 6:54 PM
swills requested changes to this revision.Feb 24 2015, 7:17 PM
swills edited edge metadata.

Please remove lang/ruby19 and edit lang/Makefile and UPDATING while doing this.

This revision now requires changes to proceed.Feb 24 2015, 7:17 PM
rene updated this revision to Diff 3960.Feb 24 2015, 7:30 PM
rene edited edge metadata.

Almost full diff, without lang/ruby19 diff for size reasons.

swills added a comment.Feb 24 2015, 7:34 PM

See inline commands.

MOVED
7428

s/ends/ended/

UPDATING
14

Might be good to tell folks who have DEFAULT_VERSIONS=ruby=1.9 in make.conf to remove it or change it to something else.

rene updated this revision to Diff 3963.Feb 24 2015, 7:46 PM
rene edited edge metadata.

Tweak MOVED and UPDATING

swills accepted this revision.Feb 24 2015, 7:49 PM
swills edited edge metadata.

Looks good

This revision is now accepted and ready to land.Feb 24 2015, 7:49 PM
sunpoet accepted this revision.Feb 24 2015, 8:06 PM
sunpoet edited edge metadata.

Looks good to me. Thanks.

UPDATING
13

Personally I would remove "Ruby" here.

rene closed this revision.Feb 24 2015, 8:15 PM

Committed as r379837

Revision Contents
Changeset List

PathSize
1 line
Mk/
31 lines
9 lines
lang/
1 line

Diff 3963

View Options

MOVED

Loading...
View Options

Mk/bsd.ruby.mk

Loading...
View Options

UPDATING

Loading...
View Options

lang/Makefile

Loading...