Page MenuHomeFreeBSD

Don't print all the I/O we abort on a reset, unless we're out of retries.
ClosedPublic

Authored by imp on Mar 3 2019, 3:38 AM.

Details

Summary

When resetting the controller, we abort I/O. Prior to this fix, we
printed a ton of abort messages for I/O that we're going to
retry. This imparts no useful information. Stop printing them unless
our retry count is exhausted. Clarify code for when we don't retry,
and remove useless arg to a routine that's always called with it
as 'true'.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Mar 3 2019, 4:38 PM
jimharris added inline comments.
sys/dev/nvme/nvme_qpair.c
39 ↗(On Diff #54627)

Functionally this patch looks fine. I'd probably be more descriptive in the enum names just so they're more clear when used. i.e. ERROR_PRINT_NONE, ERROR_PRINT_NO_MORE_RETRY (or ERROR_PRINT_RETRIES_EXHAUSTED), ERROR_PRINT_ALL.

This revision was automatically updated to reflect the committed changes.