bectl(8): change jail command to execute jail(8)

[jwmaag_gmail.com]

Summary

Change bectl to read in -o flags and put them in a nvlist
then depending on whether we are interactive or not, use libjail
or the jail command to initalize our jail.

[kevans]

As we discussed, I no longer have any qualms with dropping jail(3) completely and proxying it all through to jail(8).

sbin/bectl/bectl_jail.c

65 ↗

(On Diff #54184)

style(9) nit: there should be a blank line following any declarations, or simply a blank line at the beginning if there are no declarations.

72 ↗

(On Diff #54184)

Same as above: blank line before nvlist_remove_all.

89 ↗

(On Diff #54184)

This looks like an accidental trailing space crawled in

227 ↗

(On Diff #54184)

No spaces around these and a space after the parentheses before the opening brace.; if (nvlist_exists(...) || nvlist_exists(...)) { (with wrapping, of course)

261 ↗

(On Diff #54184)

Space before the opening brace here

286 ↗

(On Diff #54184)

Spacing

310 ↗

(On Diff #54184)

Take a look at sbuf(9) for this; you can drop all of the argument tracking in favor of sbuf_new_auto() and a series of sbuf_cat()/sbuf_printf() depending on whether you need formatting or you're just appending /usr/sbin/jail.

[kevans]

sbin/bectl/bectl_jail.c

232 ↗

(On Diff #54184)

Don't do this

236 ↗

(On Diff #54184)

argv++, argc--

261 ↗

(On Diff #54184)

Pass argc/argv through to bectl_cmd_jail_* as needed and tack those on at the end, after all parameters

[jwmaag_gmail.com]

Remove mounts created by the jail(8) command. prevent unwanted param arguments.
Clean up jail assets on effort basis.

[jwmaag_gmail.com]

• whitespace changes

[jwmaag_gmail.com]

• handle multiple arguments passed in command

[jwmaag_gmail.com]

• more whitespace changes

[jwmaag_gmail.com]

• noticed a few more style issues

[jwmaag_gmail.com]

• clean up allocated jail command arguments