Paths

Table of Contentst

Differential D19269

net/py-zeroconf: Update dependencies and add tests
ClosedPublic
Actions

Authored by 0mp on Feb 20 2019, 1:39 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Sep 23, 11:44 PM

	Unknown Object (File)
	Wed, Sep 23, 11:40 PM

	Unknown Object (File)
	Wed, Sep 23, 11:38 PM

	Unknown Object (File)
	Wed, Sep 23, 11:37 PM

	Unknown Object (File)
	Thu, Sep 17, 6:36 AM

	Unknown Object (File)
	Mon, Sep 14, 12:44 PM

	Unknown Object (File)
	Sun, Sep 13, 6:36 AM

	Unknown Object (File)
	Fri, Sep 11, 1:11 AM

Subscribers

None

Details

Reviewers

jhixson
mat
krion

Commits

rP495339: net/py-zeroconf: Update dependencies and add tests

Summary

Set LICENSE_FILE
Add tests
- One test (test_lots_of_names) is disabled now as it fails
Remove six from dependencies (support for Python 2 was dropped in https://github.com/jstasiak/python-zeroconf/commit/f22f421e4e6bf1ca7671b1eb540ba09fbf1e04b1)
Improve package description

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236019

Test Plan

portlint
poudriere testport
Test the test suite: echo 'cd /usr/ports/net/py-zeroconf && make test' | sudo poudriere bulk -Ctr -j 112a -i net/py-zeroconf

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

0mp created this revision.Feb 20 2019, 1:39 PM

Harbormaster completed remote builds in B22617: Diff 54136.Feb 20 2019, 1:39 PM

0mp edited the test plan for this revision. (Show Details)Feb 20 2019, 1:41 PM

mat added inline comments.Feb 20 2019, 4:27 PM

net/py-zeroconf/pkg-descr
7–12 ↗	(On Diff #54136)	While all these are interesting, the FreeBSD port already does all these choices for you, so I am unsure if they are of any interest.

0mp added inline comments.Feb 21 2019, 5:29 PM

net/py-zeroconf/pkg-descr
7–12 ↗	(On Diff #54136)	Fair point, although I'd probably leave points 1-3. Those about pip and PyPI can go.

Remove uninteresting bits from pkg-descr.

Harbormaster completed remote builds in B22714: Diff 54337.Feb 25 2019, 11:01 AM

mat accepted this revision.Feb 25 2019, 6:22 PM

This revision is now accepted and ready to land.Feb 25 2019, 6:22 PM

0mp edited the summary of this revision. (Show Details)Mar 5 2019, 3:08 PM

Closed by commit rP495339: net/py-zeroconf: Update dependencies and add tests (authored by 0mp). · Explain WhyMar 11 2019, 10:20 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

net/

py-zeroconf/

11 lines

6 lines

Diff 54917

head/net/py-zeroconf/Makefile

Loading...

head/net/py-zeroconf/pkg-descr

Loading...