This is a simple update of a port, just an update to version 1.0.
Additionally to other things inside the new version, I made two changes in
the port itself. I could not find answers for some questions about them,
so I ask here.
- The port uses Python. It works with Python 2.7 and 3.6. But it depends on
two libraries flavored for py27 and py3*. Previously, I used in Makefile
USE_PYTHON=optsuffix. Now this is deprecated, as also is PYTHON_PKGNAMESUFFIX.
Is defining PKGNAMESUFFIX=-py${PYTHON_SUFFIX} a correct way to get rid of
optsuffix?
I noticed that an update of the optsuffix version to PKGNAMESUFFIX one
with portmaster leads to the following error.
... ====> Running Q/A tests (stage-qa) ===> Installing for porttree-py27-1.0.r99 ===> Checking if porttree-py27 already installed ===> Registering installation for porttree-py27-1.0.r99 Installing porttree-py27-1.0.r99... pkg-static: porttree-py27-1.0.r99 conflicts with porttree-1.0.r99 (installs files into the same place). Problematic file: /usr/local/bin/porttree *** Error code 70 Stop. make: stopped in /usr/ports/ports-mgmt/porttree ===>>> Installation of porttree-py27-1.0.r99 (ports-mgmt/porttree) failed ===>>> Aborting update
Surely, this is easily fixed by 'sudo pkg delete porttree-1.0.r99' and
reinstalling with portmaster.
Does this need mentioning in UPDATING?
- I added some tests to the port. Is it OK to run the tests from ${WRKSRC}
or should I first install them to ${STAGEDIR} and run from there?
BTW, in src it's porttree.py, and in stage it's just porttree.
Does this make difference?
The tests create a temp file (cache) in /tmp (and delete it on exit or
interrupt). Is this acceptable?