Page MenuHomeFreeBSD

postgresql using flavors
Needs ReviewPublic

Authored by girgen on Fri, Feb 8, 12:12 PM.

Details

Reviewers
tz
mat
Summary

Use flavors for postgresql-server

  • noxml
  • llvmjit
Test Plan

test that llvm JIT is in fact used when chosen

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

girgen created this revision.Fri, Feb 8, 12:12 PM
mat added a comment.Fri, Feb 8, 3:05 PM

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

Also, could you please remove all whitespace only changes.

databases/postgresql11-server/Makefile
128–139

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

Also, as you set FLAVOR?=, you can remove the :U in the .if.

Also, move the *_PKGNAMESUFFIX out of the .if.

195–199

This should probably be using LLVM_DEFAULT instead of creating a new LLVM_VERSION.

girgen updated this revision to Diff 53766.Mon, Feb 11, 11:00 AM
girgen added a reviewer: mat.