Differential D19009

Disable LibVNC/libvncserver cmake default options
ClosedPublic
Actions

Authored by dereks_lifeofadishwasher.com on Jan 29 2019, 12:04 AM.

Details

Reviewers

Commits

Summary

All cmake options default to YES so When building on a host system with
non-option or non-DEPENDS libs installed it's possible cmake will find
these and build parts of libvncserver that are not supported at this
time.

Disable all non-option and non-DEPENDS cmake options for now.
Enable cmake options that don't have ports options from USES= or that
can be found in the base system.

Test Plan

portlint, testport, bulk, test with virtualbox-ose

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 22267
Build 21467: arc lint + arc unit

Event Timeline

dereks_lifeofadishwasher.com created this revision.Jan 29 2019, 12:04 AM

Harbormaster completed remote builds in B22234: Diff 53350.Jan 29 2019, 12:04 AM

Based on comments from https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234929
the last patch disabled some functionality with libvncserver. Also added SASL
support with patch to fix a build error.

Harbormaster completed remote builds in B22267: Diff 53413.Jan 30 2019, 5:03 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 31 2019, 1:47 AM

Closed by commit rP491673: - Add CMAKE options properly. (authored by araujo). · Explain Why

This revision was automatically updated to reflect the committed changes.