Page MenuHomeFreeBSD
Differential D18978

[new port] sysutils/conman - serial console manager
ClosedPublic
Actions

Authored by jhixson on Jan 26 2019, 12:34 AM.
Tags
None
Referenced Files
F165223159: D18978.id53236.diff
Thu, Aug 6, 11:19 PM
F165209124: D18978.id53438.diff
Thu, Aug 6, 8:22 PM
F165197558: D18978.id.diff
Thu, Aug 6, 5:43 PM
Unknown Object (File)
Tue, Aug 4, 8:44 AM
Unknown Object (File)
Tue, Aug 4, 8:26 AM
Unknown Object (File)
Tue, Aug 4, 3:24 AM
Unknown Object (File)
Tue, Aug 4, 2:08 AM
Unknown Object (File)
Mon, Aug 3, 9:19 AM
View All Files
Subscribers
mat

Details

Reviewers
araujo
miwi
Commits
rP491681: [New port] sysutils/conman - serial console manager
Summary

[new port] sysutils/conman - serial console manager

Test Plan

Tested with poudriere for 11.2 and 12.0

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhixson created this revision.Jan 26 2019, 12:34 AM
Herald added a subscriber: mat. · View Herald TranscriptJan 26 2019, 12:34 AM
Harbormaster completed remote builds in B22171: Diff 53236.Jan 26 2019, 12:34 AM
araujo added inline comments.Jan 29 2019, 3:36 AM
sysutils/conman/pkg-plist
3 ↗(On Diff #53236)

Is it correct or there is a file name missing here?

jhixson added inline comments.Jan 29 2019, 4:31 AM
sysutils/conman/pkg-plist
3 ↗(On Diff #53236)

This is definitely wrong. I will fix this.

jhixson updated this revision to Diff 53363.Jan 29 2019, 5:05 AM

sysutils/conman: Fix ETCDIR and pkg-plist to have correct files

Harbormaster completed remote builds in B22243: Diff 53363.Jan 29 2019, 5:05 AM
Harbormaster completed remote builds in B22243: Diff 53363.
jhixson marked an inline comment as done.Jan 29 2019, 5:06 AM
mat added inline comments.Jan 29 2019, 4:27 PM
sysutils/conman/pkg-plist
4–5 ↗(On Diff #53363)

I do not think the default and init.d file will ever be used by anything at all.

6 ↗(On Diff #53363)

I don't know if we have a logrotate port, but if we have, this should be a @sample to make it user editable.

3 ↗(On Diff #53236)

The correct fix would have been to simply write etc/conman here instead of changing everything else.

jhixson updated this revision to Diff 53438.Jan 30 2019, 7:46 PM

sysutils/conman: port fixes

  • Use %%ETCDIR%%
  • Use @sample for config files
  • Patch Makefile.in to install sample files
Harbormaster completed remote builds in B22277: Diff 53438.Jan 30 2019, 7:46 PM
jhixson marked 3 inline comments as done.Jan 30 2019, 7:47 PM
araujo accepted this revision.Jan 31 2019, 2:19 AM
This revision is now accepted and ready to land.Jan 31 2019, 2:19 AM
Closed by commit rP491681: [New port] sysutils/conman - serial console manager (authored by jhixson). · Explain WhyJan 31 2019, 4:56 AM
This revision was automatically updated to reflect the committed changes.
mat added a comment.Jan 31 2019, 7:32 AM

What about removing all these ETCDIR changes that were not needed?

Revision Contents
Changeset List

PathSize
head/
sysutils/
1 line
conman/
44 lines
3 lines
files/
29 lines
39 lines
12 lines
32 lines

Diff 53459

View Options

head/sysutils/Makefile

Loading...
View Options

head/sysutils/conman/Makefile

Loading...
View Options

head/sysutils/conman/distinfo

Loading...
View Options

head/sysutils/conman/files/conmand.in

Loading...
View Options

head/sysutils/conman/files/patch-Makefile.in

Loading...
View Options

head/sysutils/conman/pkg-descr

Loading...
View Options

head/sysutils/conman/pkg-plist

Loading...