Page MenuHomeFreeBSD
Differential D18965

Enable PCI bar reallocation by default.
ClosedPublic
Actions

Authored by jhb on Jan 25 2019, 6:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 12:19 AM
Unknown Object (File)
Thu, Dec 12, 8:02 PM
Unknown Object (File)
Thu, Dec 12, 7:26 PM
Unknown Object (File)
Mon, Dec 2, 10:37 PM
Unknown Object (File)
Mon, Dec 2, 10:31 PM
Unknown Object (File)
Mon, Dec 2, 10:30 PM
Unknown Object (File)
Oct 26 2024, 7:35 AM
Unknown Object (File)
Sep 18 2024, 6:33 AM
View All 38 Files
Subscribers
None

Details

Reviewers
imp
Commits
rS344022: Enable PCI BAR reallocation by default.
Summary

When pci_realloc_bars was first added, the intention was to eventually
enable it by default, but it was left disabled to preserve existing
behavior. The setting is pretty conservative in that it does not
attempt to allocate resources for BARs that the BIOS/firmware leaves
disabled. It only attempts to reallocate resources for a BAR that the
firmware programmed during boot but that conflicts with another
resource during the kernel's device scan.

PR 221350 is an example of a machine that this knob fixes.

Test Plan
  • booted my test VM's, but they don't have conflicts

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Jan 25 2019, 6:40 PM
Harbormaster completed remote builds in B22156: Diff 53215.Jan 25 2019, 6:40 PM
jhb added a comment.Feb 7 2019, 5:57 PM

Ping?

imp accepted this revision.Feb 9 2019, 4:03 AM

I thought we did this years ago...
Now is a great time to do it. If there are issues, we'll find out in plenty of time to either (a) fix or (b) chicken out.

This revision is now accepted and ready to land.Feb 9 2019, 4:03 AM
Closed by commit rS344022: Enable PCI BAR reallocation by default. (authored by jhb). · Explain WhyFeb 11 2019, 8:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
pci/
2 lines

Diff 53803

View Options

head/sys/dev/pci/pci.c

Loading...