Page MenuHomeFreeBSD

x11/polybar: fix build on 13-CURRENT
ClosedPublic

Authored by rigoletto on Dec 15 2018, 2:02 AM.

Details

Summary

Polybar is broken on CURRENT. I don't have a CURRENT box but I managed to reproduce the breakage on 12R forcing llvm70 on it.

I set the port to use llvm60, but is there a way to just a apply those changes on 13, to avoid the need of build llvm60 when there is no actual necessity? I mean, like a helper or something. I think I already saw something for that in the handbook but I am not finding it now.

Test Plan

Needs test on a CURRENT box.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rigoletto edited the test plan for this revision. (Show Details)

Could you try to fix the build with clang7? What is the error you get?

x11/polybar/Makefile
19 ↗(On Diff #52038)

^ there should be a connection between the 60 here and below

39 ↗(On Diff #52038)

^ I would not misues LLVM_DEFAULT for this :)

rigoletto marked 2 inline comments as done.
  • fix BUILD_DEPENDS
  • remove LLVM_DEFAULT
  • apply the changes just to CURRENT

Minor, just remove an extra "+".

Btw, the OSVERSION is ate the end because was portlint compling about bsd.port.pre.mk before OPTIONS.

Thanks!

Revert the port and add upstream patch fxing the build. :-D

Thanks!

I would simply use the raw content from the commit as patch :)

x11/polybar/Makefile
18 ↗(On Diff #52061)

^ revert

I would prefer the upstream patch directly :) - but if it does not apply after de-gitifying, go ahead.

This revision is now accepted and ready to land.Dec 19 2018, 10:03 PM

Keep the headers in the patch. Thanks!

This revision now requires review to proceed.Dec 19 2018, 10:08 PM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 19 2018, 11:23 PM
This revision was automatically updated to reflect the committed changes.