Page MenuHomeFreeBSD

Improve style/consistency among ports maintained by jbeich
ClosedPublic

Authored by jbeich on Feb 16 2015, 6:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 4:00 PM
Unknown Object (File)
Thu, Apr 18, 2:10 PM
Unknown Object (File)
Thu, Apr 18, 2:10 PM
Unknown Object (File)
Thu, Apr 18, 2:10 PM
Unknown Object (File)
Wed, Apr 17, 10:50 AM
Unknown Object (File)
Wed, Apr 17, 8:24 AM
Unknown Object (File)
Thu, Mar 28, 3:19 PM
Unknown Object (File)
Feb 23 2024, 10:11 AM
Subscribers
None

Details

Reviewers
bapt
Summary

Improve style/consistency among ports I maintain

  • Convert to COPYTREE_SHARE
  • Drop unnecessary MKDIR before COPYTREE_SHARE
  • Drop bsd.port.options.mk if only DOCS requires it without dependencies
  • Use separate backup if several REINPLACE_CMD against same file
  • audio/alsa-utils: convert to LIBS
Test Plan

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

jbeich retitled this revision from to Improve style/consistency among ports maintained by jbeich.
jbeich updated this object.
jbeich edited the test plan for this revision. (Show Details)
jbeich added a reviewer: bapt.

Hmm, all those cases of

	${MKDIR} ${STAGEDIR}${DOCSDIR}
	${INSTALL_MAN} ${PORTDOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}

can be replaced with

	(cd ${WRKSRC} && ${COPYTREE_SHARE} \
		"${PORTDOCS}" ${STAGEDIR}${DOCSDIR})
  • Convert INSTALL_MAN uses to COPYTREE_SHARE
bapt edited edge metadata.
This revision is now accepted and ready to land.Feb 16 2015, 7:53 AM