Page MenuHomeFreeBSD

Improve style/consistency among ports maintained by jbeich
ClosedPublic

Authored by jbeich on Feb 16 2015, 6:32 AM.

Details

Reviewers
bapt
Summary

Improve style/consistency among ports I maintain

  • Convert to COPYTREE_SHARE
  • Drop unnecessary MKDIR before COPYTREE_SHARE
  • Drop bsd.port.options.mk if only DOCS requires it without dependencies
  • Use separate backup if several REINPLACE_CMD against same file
  • audio/alsa-utils: convert to LIBS
Test Plan

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

jbeich retitled this revision from to Improve style/consistency among ports maintained by jbeich.Feb 16 2015, 6:32 AM
jbeich updated this object.
jbeich edited the test plan for this revision. (Show Details)
jbeich added a reviewer: bapt.
jbeich updated this revision to Diff 3788.

Hmm, all those cases of

	${MKDIR} ${STAGEDIR}${DOCSDIR}
	${INSTALL_MAN} ${PORTDOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}

can be replaced with

	(cd ${WRKSRC} && ${COPYTREE_SHARE} \
		"${PORTDOCS}" ${STAGEDIR}${DOCSDIR})
jbeich updated this revision to Diff 3792.Feb 16 2015, 7:03 AM
  • Convert INSTALL_MAN uses to COPYTREE_SHARE
jbeich updated this object.Feb 16 2015, 7:06 AM
bapt edited edge metadata.Feb 16 2015, 7:53 AM
bapt accepted this revision.
This revision is now accepted and ready to land.Feb 16 2015, 7:53 AM
jbeich closed this revision.Feb 16 2015, 8:16 AM

Closed by commit rP379072 (authored by @jbeich).