netdump: Add ddb 'show netdumpconf' command

[markj]

sys/netinet/netdump/netdump_client.c

1330

The casts to unsigned here and below shouldn't be needed.

1336

I was going to suggest this too. Maybe have a generic "show dumpdev" or whatever which calls a function in the netdump code to print additional parameters.

[cem]

sys/netinet/netdump/netdump_client.c

1330

Why not? nd_server_port is a uint16_t; the kda casts below are uint8_t.

nd_seqno is uint32_t, which I guess is the same size as unsigned on all supported FreeBSD architectures; that one could be dropped.

1336

That seems reasonable. I probably won't have time to work on that until at least Sunday — three different family gatherings this week 🥳🤯😱.

[markj]

sys/netinet/netdump/netdump_client.c

1330

Sorry, I didn't think that through. I think they're unneeded if you also change the format specifier to %d, which should be fine since nd_server_port and the kda fields fit in an int. It's not important. :)

[cem]

I won't necessarily have time to work on this soon (this diff is from like a year ago), but annotate the differential such that it isn't in any "waiting on reviewers" queue. The right db command, discussed above, is probably a generic show dumperinfo.

Also, poachable.