Fix pkg-plist by using PLIST_SUB instead of PLIST_FILES

[dumbbell]

Summary

Before this change, the final plist was made of a basic pkg-plist, plus files added through the PLIST_FILES variable in the Makefile, depending on the selected options. This didn't work for the LUA option, which require @dirrm entries.

Now, the Makefile uses PLIST_SUB, which allows to have a complete pkg-plist where some entries are commentted out when the associated option is disabled.

PR: 190516.
Tested by: Matthieu Volat <[e-mail]>

Test Plan

• make stage check-orphans -- passed with all options checked, then all unchecked
• portlint -Aabt -- 1 warning about PORTDOCS (false positive)

[bapt]

Just remove all the PLIST_SUB line and add a single OPTIONS_SUB=yes earlier

[dumbbell]

Thank you Baptiste, I made that change.

While here, I added USES=gettext. It was missing and portlint started to report it. The list of USES is now sorted alphabetically.

[bapt]

Using options helpers allows you to remove all those .if ${PORT*
and to remove the .include <bsd.port.pre.mk>

I added a couple of examples in inline comments, see: http://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html §5.2.3

graphics/darktable/Makefile

53

The above can become:

GPHOTO_LIB_DEPENDS= libgphoto2.so:${PORTSDIR}/graphics/libgphoto2
GPHOTO_CMAKE_OFF= -DUSE_CAMERA_SUPPORT:BOOL=OFF

65–66

RAWSPEED_CMAKE_ON= -DDONT_USE_RAWSPEED:BOOL=ON

85–86

SLIDESHOW_USE= GL=gl SDL=sdl

91–92

NLS_USES= gettext

[dumbbell]

If I remove the ".include <bsd.port.pre.mk>" line, ${OSVERSION} isn't defined (used to check if USE_GCC is required or not).

Should I keep ".include <bsd.port.pre.mk>", or should I use another include?

[bapt]

Remove bsd.port.pre.mk and replace bsd.port.post.mk by bsd.port.mk

[dumbbell]

That's what I tried, but make(1) complains because:

• ${OSVERSION} is undefined (needed to check if USE_GCC is mandatory)
• ${PORT_OPTIONS:MDOCS} is undefined too (used in post-install)

[dumbbell]

Here's a new patch with the following changes:

• Use MYOPTION_* option-dependent variables
• Sort MYOPTION_* variables alphabetically
• Remove post-patch target, it's already integrated upstream
• Remove part of post-install reinplace, it's already upstream
• Use %%NLS%% in pkgp-list
• Add missing doc files in pkg-plist and post-install's rm

[dumbbell]

Two changes in this new revision:

• Include bsd.port.options.mk/bsd.port.mk instead of bsd.port.pre.mk/bsd.port.post.mk.
• If WITH_DEBUG is set, set CMAKE_BUILD_TYPE to RelWithDebInfo, because Debug triggers a fatal error in darktable's CMakeLists.txt. Furthermore, clear the STRIP variable, otherwise binaries are stripped.

[bapt]

Approved :)

[dumbbell]

Committed in r357572.