Page MenuHomeFreeBSD

sysutils/fswatch-mon: Update to 1.13.0
ClosedPublic

Authored by 0mp on Oct 23 2018, 1:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 6:31 AM
Unknown Object (File)
Sat, Nov 2, 7:07 AM
Unknown Object (File)
Oct 22 2024, 1:53 PM
Unknown Object (File)
Sep 24 2024, 8:00 AM
Unknown Object (File)
Sep 24 2024, 4:46 AM
Unknown Object (File)
Sep 23 2024, 2:19 PM
Unknown Object (File)
Sep 23 2024, 8:16 AM
Unknown Object (File)
Sep 22 2024, 8:24 PM
Subscribers
None

Details

Summary

Bugzilla: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232556

Test Plan
  • portlint OK
  • poudriere
    • i386:
      • 11.2-RELEASE
      • 12.0-ALPHA9
    • amd64
      • 11.2-RELEASE
      • 12.0-BETA1

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

krion requested changes to this revision.Oct 23 2018, 5:14 PM
krion added inline comments.
sysutils/fswatch-mon/Makefile
7 ↗(On Diff #49500)

Why not USE_GITHUB?

This revision now requires changes to proceed.Oct 23 2018, 5:14 PM
0mp marked an inline comment as done.Oct 23 2018, 5:25 PM
0mp added inline comments.
sysutils/fswatch-mon/Makefile
7 ↗(On Diff #49500)

Because the upstream prepares a release for us so that we don't have to bootstrap everything from scratch with autotools.

On the other hand, the release package is heavier than a source code tarball.

0mp marked an inline comment as done.Nov 16 2018, 1:41 PM
0mp added inline comments.
sysutils/fswatch-mon/Makefile
7 ↗(On Diff #49500)

Do you think that we should switch to USE_GITHUB for easier maintenance?

mat added inline comments.
sysutils/fswatch-mon/Makefile
7 ↗(On Diff #49500)

No, we should always use the released tarballs when they are available. (Unless they're broken, of course.)

USE_GITHUB use git-archive(1) under the hood and should only be used if no released distribution file is available.

@krion, is it fine with you if I commit this change?

This revision is now accepted and ready to land.Nov 23 2018, 3:08 PM
This revision was automatically updated to reflect the committed changes.