Page MenuHomeFreeBSD
Differential D17636

lang/ghc: Cosmetic fixes to Makefile and build.mk files.
ClosedPublic
Actions

Authored by arrowd on Oct 21 2018, 7:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 4:58 AM
Unknown Object (File)
Thu, Nov 14, 7:29 AM
Unknown Object (File)
Thu, Nov 14, 4:15 AM
Unknown Object (File)
Sat, Nov 9, 3:44 PM
Unknown Object (File)
Oct 26 2024, 7:33 AM
Unknown Object (File)
Sep 24 2024, 11:50 AM
Unknown Object (File)
Sep 8 2024, 10:47 AM
Unknown Object (File)
Aug 18 2024, 11:32 PM
View All 42 Files
Subscribers
None

Details

Reviewers
tcberner
Commits
rP482720: lang/ghc: Cosmetic changes to Makefile and build.mk files.
Test Plan

Built the port with various combinations of OPTIONS as well as with xelatex installed.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arrowd created this revision.Oct 21 2018, 7:58 AM
Harbormaster completed remote builds in B20319: Diff 49387.Oct 21 2018, 7:58 AM
tcberner added a comment.Oct 21 2018, 8:22 AM

YES/NO looks indeed to be the propper way: https://ghc.haskell.org/trac/ghc/wiki/Building/Using

lang/ghc/files/build.mk.in
10 ↗(On Diff #49387)

^don't we lose the pdf by that -- or did we never even install the genrated one?

arrowd marked an inline comment as done.Oct 21 2018, 9:44 AM
arrowd added inline comments.
lang/ghc/files/build.mk.in
10 ↗(On Diff #49387)

If I get this right, we didn't have PDF in first place due to this xelatex bug.

tcberner added inline comments.Oct 21 2018, 10:06 AM
lang/ghc/files/build.mk.in
10 ↗(On Diff #49387)

is the dependency on sphinx still needed? (I assume it is for the _HTML docs).

arrowd marked an inline comment as done.Oct 21 2018, 10:11 AM
arrowd added inline comments.
lang/ghc/files/build.mk.in
10 ↗(On Diff #49387)

The link you posted says that sphinx is used for both HTML and PDF docs, so yes, we still need to have it.

tcberner accepted this revision.Oct 21 2018, 12:23 PM

In that case, it looks fine to me.

This revision is now accepted and ready to land.Oct 21 2018, 12:23 PM
Closed by commit rP482720: lang/ghc: Cosmetic changes to Makefile and build.mk files. (authored by arrowd). · Explain WhyOct 21 2018, 6:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
lang/
ghc/
12 lines
files/
7 lines
8 lines

Diff 49406

View Options

head/lang/ghc/Makefile

Loading...
View Options

head/lang/ghc/files/build.boot.mk.in

Loading...
View Options

head/lang/ghc/files/build.mk.in

Loading...