Page MenuHomeFreeBSD
Differential D17395

Documentation changes.
ClosedPublic
Actions

Authored by rigoletto on Oct 3 2018, 8:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 1 2024, 5:13 AM
Unknown Object (File)
Dec 24 2023, 6:17 PM
Unknown Object (File)
Sep 2 2023, 6:59 PM
Unknown Object (File)
May 22 2023, 8:46 PM
Unknown Object (File)
Dec 22 2022, 12:16 AM
Unknown Object (File)
Dec 10 2022, 7:33 AM
Subscribers
None

Details

Reviewers
tcberner
mat
Commits
rD52333: Add myself to authors, developers, and news.
Summary

Documentations changes by the FreeBSD Committers Guide.

Test Plan

the pgp key script left the key on the doc directory. Due to lack of
information fo better I left it in there.

Thanks.

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rigoletto created this revision.Oct 3 2018, 8:47 PM
Harbormaster completed remote builds in B19939: Diff 48693.Oct 3 2018, 8:47 PM
tcberner added inline comments.Oct 3 2018, 9:20 PM
share/xml/news.xml
45 ↗(On Diff #48693)

^ I think you're missing a </month>

mat added a comment.Oct 4 2018, 8:56 AM

The key is in the wrong directory.

share/xml/authors.ent
1962 ↗(On Diff #48693)

You need to use entities, can't use utf-8 here.

share/xml/news.xml
41 ↗(On Diff #48693)

You probably need to use entities here too, no utf-8.

rigoletto updated this revision to Diff 48721.Oct 4 2018, 2:36 PM
rigoletto marked 3 inline comments as done.

Done. :-)

Harbormaster completed remote builds in B19960: Diff 48721.Oct 4 2018, 2:36 PM
mat added a comment.Oct 4 2018, 3:11 PM

Also, I would like to see the commit message you plan to use.

share/xml/news.xml
46–48 ↗(On Diff #48721)

There seem to be a indentation issue here.

rigoletto updated this revision to Diff 48727.Oct 4 2018, 3:37 PM

Done.

Harbormaster completed remote builds in B19966: Diff 48727.Oct 4 2018, 3:37 PM
rigoletto added a comment.Oct 4 2018, 3:47 PM

Add myself to the list of developers.

Approved by: tcberner (mentor), mat (mentor)

rigoletto updated this revision to Diff 48751.Oct 4 2018, 9:04 PM

Minor.

Harbormaster completed remote builds in B19983: Diff 48751.Oct 4 2018, 9:04 PM
tcberner accepted this revision.Oct 5 2018, 8:15 PM

Looks good to me now.

This revision is now accepted and ready to land.Oct 5 2018, 8:15 PM
Closed by commit rD52333: Add myself to authors, developers, and news. (authored by rigoletto). · Explain WhyOct 5 2018, 8:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
en_US.ISO8859-1/
articles/
contributors/
4 lines
share/
pgpkeys/
5 lines
1 line
65 lines
xml/
3 lines
14 lines

Diff 48810

View Options

head/en_US.ISO8859-1/articles/contributors/contrib.committers.xml

Loading...
View Options

head/share/pgpkeys/pgpkeys-developers.xml

Loading...
View Options

head/share/pgpkeys/pgpkeys.ent

Loading...
View Options

head/share/pgpkeys/rigoletto.key

Loading...
View Options

head/share/xml/authors.ent

Loading...
View Options

head/share/xml/news.xml

Loading...