devel/mingw32-openssl: Pet portlint.
AbandonedPublic
Actions

Authored by 0mp on Oct 2 2018, 4:11 PM.

Details

Reviewers

krion
mat

Summary

Changes:

Do not start COMMENT with "The".
Define LICENSE and LICENSE_FILE.
Put USE_PERL5 in the USES section.
Install pkgconfig files into mingw32/libdata/pkgconfig instead of mingw32/lib/pkgconfig/ as suggested by portlint.

Actually, I am not sure about the pkgconfig-related change. Shouldn't those files be installed into libdata/pkgconfig?

Test Plan

portlint
poudriere: 12.0-ALPHA6 amd64

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 29914
Build 27733: arc lint + arc unit

Event Timeline

0mp created this revision.Oct 2 2018, 4:11 PM

Harbormaster completed remote builds in B19909: Diff 48651.Oct 2 2018, 4:11 PM

0mp added a subscriber: knu.Oct 2 2018, 4:12 PM

mat added inline comments.Oct 3 2018, 8:42 AM

devel/mingw32-openssl/Makefile
42–45	That is most probably not needed.

The pkgconfig files are most certainly not used by anything, they should not be installed in PREFIX/libdata/pkgconfig because then they would conflict with security/openssl.

Do not touch pkgconfig-related stuff.
Reimplement do-configure with standard *CONFIGURE* variables.
- This requires setting CC to "gcc" in the environment as the default value of "cc" breaks the build. This behavior can be observed now because the default CONFIGURE_ENV is passed to the configure script after this refactoring.
Convert a REINPLACE_CMD use with a patch.
Sort variables.
Bump PORTREVISION after adding license information.