Page MenuHomeFreeBSD

rtld-elf should use powerof2() (PR 192238)
ClosedPublic

Authored by cse_cem_gmail_com on Jan 29 2015, 5:53 PM.

Details

Summary

This is a minor clean-up. Additionally, explicitly check for a valid nmaskwords.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

cse_cem_gmail_com retitled this revision from to rtld-elf should use powerof2(); nmaskwords must not be zero (PR 192238).
cse_cem_gmail_com updated this object.
cse_cem_gmail_com edited the test plan for this revision. (Show Details)
cse_cem_gmail_com added reviewers: benno, emaste.
libexec/rtld-elf/rtld.c
987–988

Remove the nmw_power2 variable altogether. It was introduced only to simplify the expression for valid_gnu_hash.

The comment about 'power of 2' should be moved to valid_gnu_hash and updated.

Drop nmaskwords > 0; remove superfluous nmw_power2 variable.

cse_cem_gmail_com retitled this revision from rtld-elf should use powerof2(); nmaskwords must not be zero (PR 192238) to rtld-elf should use powerof2() (PR 192238).Jan 30 2015, 2:56 PM
This revision is now accepted and ready to land.Feb 18 2015, 4:36 PM