Page MenuHomeFreeBSD

lang/ocaml: add -znotext to LDFLAGS on i386, for lld
ClosedPublic

Authored by emaste on Sep 17 2018, 2:30 PM.

Details

Summary

Example error:

/usr/bin/ld: error: can't create dynamic relocation R_386_32 against symbol: caml_last_return_address in readonly segment; recompile object files with -fPIC

This port links some non-PIC code, which fails with lld as it defaults to disallowing relocations against read-only segments. For i386 we can just add -znotext unconditionally: for GNU BFD ld it just affirms BFD's existing default.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emaste created this revision.Sep 17 2018, 2:30 PM
lang/ocaml/Makefile
37 ↗(On Diff #48112)

Couldn’t this be eliminated and only have the LDFLAGS_i386....?

emaste marked an inline comment as done.Sep 17 2018, 7:15 PM
emaste added inline comments.
lang/ocaml/Makefile
37 ↗(On Diff #48112)

Common ports infrastructure doesn't handle arch-specific LDFLAGS the way it does CFLAGS_${ARCH}

ndowens_yahoo.com marked an inline comment as done.Sep 17 2018, 7:16 PM
ndowens_yahoo.com added inline comments.
lang/ocaml/Makefile
37 ↗(On Diff #48112)

Just found that out as well, never mind

lang/ocaml/Makefile
38 ↗(On Diff #48112)

Only thing I would change is the order as declaring a variable should come before its use

This revision was not accepted when it landed; it landed in state Needs Review.Sep 18 2018, 4:05 PM
This revision was automatically updated to reflect the committed changes.