Page MenuHomeFreeBSD
Differential D17200

lang/ocaml: add -znotext to LDFLAGS on i386, for lld
ClosedPublic
Actions

Authored by emaste on Sep 17 2018, 2:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 9:53 PM
Unknown Object (File)
Tue, Nov 19, 9:42 AM
Unknown Object (File)
Tue, Nov 5, 8:36 AM
Unknown Object (File)
Oct 18 2024, 4:37 AM
Unknown Object (File)
Oct 18 2024, 4:37 AM
Unknown Object (File)
Oct 18 2024, 2:27 AM
Unknown Object (File)
Oct 17 2024, 11:31 AM
Unknown Object (File)
Oct 16 2024, 7:03 PM
View All Files
Subscribers
mmokhi
ndowens_yahoo.com

Details

Reviewers
None
Commits
rP480033: lang/ocaml: add -znotext to LDFLAGS on i386, for lld
Summary

Example error:

/usr/bin/ld: error: can't create dynamic relocation R_386_32 against symbol: caml_last_return_address in readonly segment; recompile object files with -fPIC

This port links some non-PIC code, which fails with lld as it defaults to disallowing relocations against read-only segments. For i386 we can just add -znotext unconditionally: for GNU BFD ld it just affirms BFD's existing default.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.Sep 17 2018, 2:30 PM
emaste added a subscriber: ndowens_yahoo.com.Sep 17 2018, 6:51 PM

PR 230209

ndowens_yahoo.com added inline comments.Sep 17 2018, 7:01 PM
lang/ocaml/Makefile
37 ↗(On Diff #48112)

Couldn’t this be eliminated and only have the LDFLAGS_i386....?

emaste marked an inline comment as done.Sep 17 2018, 7:15 PM
emaste added inline comments.
lang/ocaml/Makefile
37 ↗(On Diff #48112)

Common ports infrastructure doesn't handle arch-specific LDFLAGS the way it does CFLAGS_${ARCH}

ndowens_yahoo.com marked an inline comment as done.Sep 17 2018, 7:16 PM
ndowens_yahoo.com added inline comments.
lang/ocaml/Makefile
37 ↗(On Diff #48112)

Just found that out as well, never mind

ndowens_yahoo.com added inline comments.Sep 17 2018, 7:18 PM
lang/ocaml/Makefile
38 ↗(On Diff #48112)

Only thing I would change is the order as declaring a variable should come before its use

This revision was not accepted when it landed; it landed in state Needs Review.Sep 18 2018, 4:05 PM
Closed by commit rP480033: lang/ocaml: add -znotext to LDFLAGS on i386, for lld (authored by emaste). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
lang/
ocaml/
1 line

Diff 48171

View Options

head/lang/ocaml/Makefile

Loading...