lang/ocaml: add -znotext to LDFLAGS on i386, for lld

[emaste]

Summary

Example error:

/usr/bin/ld: error: can't create dynamic relocation R_386_32 against symbol: caml_last_return_address in readonly segment; recompile object files with -fPIC

This port links some non-PIC code, which fails with lld as it defaults to disallowing relocations against read-only segments. For i386 we can just add -znotext unconditionally: for GNU BFD ld it just affirms BFD's existing default.

[emaste]

PR 230209

[ndowens_yahoo.com]

lang/ocaml/Makefile

37 ↗

(On Diff #48112)

Couldn’t this be eliminated and only have the LDFLAGS_i386....?

[emaste]

lang/ocaml/Makefile

37 ↗

(On Diff #48112)

Common ports infrastructure doesn't handle arch-specific LDFLAGS the way it does CFLAGS_${ARCH}

[ndowens_yahoo.com]

lang/ocaml/Makefile

37 ↗

(On Diff #48112)

Just found that out as well, never mind

[ndowens_yahoo.com]

lang/ocaml/Makefile

38 ↗

(On Diff #48112)

Only thing I would change is the order as declaring a variable should come before its use