multimedia/xvid: link with -znotext on i386
ClosedPublic
Actions

Authored by emaste on Sep 17 2018, 1:45 PM.

Tags

None

Referenced Files

	F81725330: D17195.diff
	Sat, Apr 20, 1:21 PM

	Unknown Object (File)
	Fri, Apr 19, 6:31 AM

	Unknown Object (File)
	Thu, Mar 28, 1:35 PM

	Unknown Object (File)
	Mon, Mar 25, 5:27 PM

	Unknown Object (File)
	Mar 15 2024, 10:10 AM

	Unknown Object (File)
	Mar 15 2024, 10:08 AM

	Unknown Object (File)
	Mar 15 2024, 10:08 AM

	Unknown Object (File)
	Mar 11 2024, 2:16 PM

View All 44 Files

Subscribers

mmokhi

Details

Reviewers

riggs

Commits

rP480032: multimedia/xvid: link with -znotext on i386

Summary

This port links some non-PIC code, which fails with lld as it defaults to disallowing relocations against read-only segments. For i386 we can just add -znotext unconditionally: for GNU BFD ld it just affirms BFD's existing default.

PR: 230208

Aside: as I am not a ports committer I'm looking for one to provide explicit approval for commit.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste created this revision.Sep 17 2018, 1:45 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 18 2018, 4:04 PM

Closed by commit rP480032: multimedia/xvid: link with -znotext on i386 (authored by emaste). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

multimedia/

xvid/

Makefile

4 lines

Diff 48106

View Options

multimedia/xvid: link with -znotext on i386ClosedPublicActions