Page MenuHomeFreeBSD
Differential D17195

multimedia/xvid: link with -znotext on i386
ClosedPublic
Actions

Authored by emaste on Sep 17 2018, 1:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 10 2024, 1:18 PM
Unknown Object (File)
Dec 5 2024, 1:43 PM
Unknown Object (File)
Nov 25 2024, 8:47 PM
Unknown Object (File)
Nov 24 2024, 2:05 AM
Unknown Object (File)
Nov 23 2024, 8:42 PM
Unknown Object (File)
Nov 23 2024, 2:08 PM
Unknown Object (File)
Nov 20 2024, 6:28 AM
Unknown Object (File)
Nov 19 2024, 8:21 PM
View All Files
Subscribers
mmokhi

Details

Reviewers
riggs
Commits
rP480032: multimedia/xvid: link with -znotext on i386
Summary

This port links some non-PIC code, which fails with lld as it defaults to disallowing relocations against read-only segments. For i386 we can just add -znotext unconditionally: for GNU BFD ld it just affirms BFD's existing default.

PR: 230208

Aside: as I am not a ports committer I'm looking for one to provide explicit approval for commit.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.Sep 17 2018, 1:45 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 18 2018, 4:04 PM
Closed by commit rP480032: multimedia/xvid: link with -znotext on i386 (authored by emaste). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
multimedia/
xvid/
4 lines

Diff 48106

View Options

multimedia/xvid/Makefile

Loading...