Page MenuHomeFreeBSD
Differential D17152

shells/xonsh: Upgrade to version 0.7.8
ClosedPublic
Actions

Authored by larafercue_gmail.com on Sep 13 2018, 2:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 9:46 AM
Unknown Object (File)
Wed, Nov 6, 9:46 AM
Unknown Object (File)
Wed, Nov 6, 9:46 AM
Unknown Object (File)
Wed, Nov 6, 9:46 AM
Unknown Object (File)
Mon, Nov 4, 6:08 PM
Unknown Object (File)
Oct 21 2024, 8:33 AM
Unknown Object (File)
Oct 15 2024, 10:27 PM
Unknown Object (File)
Sep 25 2024, 11:19 AM
View All 88 Files
Subscribers
krion
mat

Details

Reviewers
0mp
mat
krion
Commits
rP479833: shells/xonsh: Upgrade to version 0.7.8
Summary

Changelog: https://github.com/xonsh/xonsh/blob/0.7.8/CHANGELOG.rst

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230369

Test Plan

portlint:ok
manual testing (12.0-ALPHA3, amd64):ok
poudriere (11.2-RELEASE, amd64):ok

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

larafercue_gmail.com created this revision.Sep 13 2018, 2:27 PM
Herald added a subscriber: mat. · View Herald TranscriptSep 13 2018, 2:27 PM
Harbormaster completed remote builds in B19566: Diff 48002.Sep 13 2018, 2:27 PM
larafercue_gmail.com added a comment.Sep 13 2018, 2:30 PM

By the way, I'm the maintainer of the port

larafercue_gmail.com edited the summary of this revision. (Show Details)Sep 13 2018, 2:32 PM
0mp accepted this revision.Sep 13 2018, 4:21 PM
0mp added reviewers: mat, krion.
0mp added a subscriber: krion.

Looks fine. Thank you!

@mat, @krion, may I have your approval to commit?

This revision is now accepted and ready to land.Sep 13 2018, 4:21 PM
krion accepted this revision.Sep 13 2018, 4:29 PM
mat added inline comments.Sep 14 2018, 10:11 AM
shells/xonsh/Makefile
20 ↗(On Diff #48002)

Why change this, it was correct before, autoplist depend on distutils.

larafercue_gmail.com updated this revision to Diff 48046.Sep 14 2018, 11:08 AM

Leaving the dependencies as they where

This revision now requires review to proceed.Sep 14 2018, 11:08 AM
Harbormaster completed remote builds in B19594: Diff 48046.Sep 14 2018, 11:08 AM
larafercue_gmail.com marked an inline comment as done.Sep 14 2018, 11:08 AM

Reverting the sorting of dependencies.

As instructed by mat@

0mp added inline comments.Sep 14 2018, 1:01 PM
shells/xonsh/Makefile
20 ↗(On Diff #48002)

Interesting. I guess we should update our handbook then: Example 6.21. Makefile for a Simple Python Module is wrong:

PORTNAME=	sample
DISTVERSION=	1.2.3
CATEGORIES=	devel

MAINTAINER=	john@doe.tld
COMMENT=	Python sample module

RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}six>0:devel/py-six@${PY_FLAVOR}

USES=		python
USE_PYTHON=	autoplist distutils

.include <bsd.port.mk>
This revision was not accepted when it landed; it landed in state Needs Review.Sep 15 2018, 12:35 PM
Closed by commit rP479833: shells/xonsh: Upgrade to version 0.7.8 (authored by 0mp). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
shells/
xonsh/
3 lines
6 lines
files/
10 lines
17 lines

Diff 48069

View Options

head/shells/xonsh/Makefile

Loading...
View Options

head/shells/xonsh/distinfo

Loading...
View Options

head/shells/xonsh/files/patch-xonsh_platform.py

Loading...
View Options

head/shells/xonsh/files/patch-xonsh_xoreutils_uptime.py

Loading...