Page MenuHomeFreeBSD

graphics/gmic-qt: Update to 2.3.6
ClosedPublic

Authored by jhale on Sep 4 2018, 1:49 AM.

Details

Reviewers
tcberner
Group Reviewers
kde
Commits
rP478988: Update to 2.3.6
Summary

Update graphics/gmic-qt to 2.3.6
This fixes build with Qt 5.11

@tcberner, your local copy of gmic_stdlib.h needs updated as well or I could put
in my distfiles. Either way.

Test Plan

Poudriere tests done on 10.4-i386, 11.1-amd64, 12.0-ALPHA3-amd64 with Qt 5.10 and Qt 5.11

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhale created this revision.Sep 4 2018, 1:49 AM
mat added inline comments.Sep 4 2018, 7:19 AM
graphics/gmic-qt/Makefile
43 ↗(On Diff #47630)
${WRKSRC_cimg}
jhale updated this revision to Diff 47634.Sep 4 2018, 8:24 AM
  • Simplify copy command
  • Fix LICENSE
  • Remove trailing slash from install
jhale marked an inline comment as done.Sep 4 2018, 8:24 AM

Fixed. Thanks!

@jhale the gmic_stdlib.h already changed again upstream. Can you send me the version you used, then I'll put it in LOCAL folder.

=> Attempting to fetch http://gmic.eu/gmic_stdlib.h
fetch: http://gmic.eu/gmic_stdlib.h: size mismatch: expected 1883290, actual 1884078
tcberner accepted this revision.Sep 4 2018, 8:00 PM

Looks good to me.

The files should be in my LOCAL/ by now.

graphics/gmic-qt/files/patch-gmic_src_gmic.cpp
1 ↗(On Diff #47634)

that should probably be upstreamed [tm]

This revision is now accepted and ready to land.Sep 4 2018, 8:00 PM
jhale added inline comments.Sep 4 2018, 8:06 PM
graphics/gmic-qt/files/patch-gmic_src_gmic.cpp
1 ↗(On Diff #47634)

I'll add it to my TODO list. :)

This revision was automatically updated to reflect the committed changes.