Page MenuHomeFreeBSD

math/labplot: Update to 2.5.0
ClosedPublic

Authored by jhale on Sep 2 2018, 10:51 PM.

Details

Reviewers
tcberner
Group Reviewers
kde
Commits
rP478934: - Update to 2.5.0
Summary

Update math/labplot to 2.5.0
Builds with Qt 5.11

Test Plan

Poudriere tests done with Qt 5.11
Still need to check for regressions with Qt 5.10

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhale created this revision.Sep 2 2018, 10:51 PM
mat added inline comments.Sep 3 2018, 6:50 AM
math/labplot/Makefile
17–33 ↗(On Diff #47599)

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

jhale updated this revision to Diff 47607.Sep 3 2018, 9:33 AM
  • Order Makefile according to PHB
  • ecm should just be a build dependency
  • Disable LIBCERF since we don't have it in the ports tree. If it ever appears, this will avoid unexpected linking.
jhale marked an inline comment as done.Sep 3 2018, 9:34 AM
tcberner accepted this revision.Sep 3 2018, 6:30 PM
tcberner added a subscriber: tcberner.

Looks good to me.

This revision is now accepted and ready to land.Sep 3 2018, 6:30 PM
This revision was automatically updated to reflect the committed changes.