Differential D1697

sfxge: Expect required init_state on data path and in periodic calls
ClosedPublic
Actions

Authored by arybchik on Jan 28 2015, 8:14 AM.

Details

Reviewers

gnn

Summary

Sponsored by: Solarflare Communications, Inc.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

arybchik updated this revision to Diff 3476.Jan 28 2015, 8:14 AM

arybchik retitled this revision from to sfxge: Expect required init_state on data path and in periodic calls.

arybchik updated this object.

arybchik edited the test plan for this revision. (Show Details)

arybchik added a reviewer: gnn.

arybchik added a subscriber: Unknown Object (MLST).

__predict_false rarely, if ever, does the right thing. Have you run any benchmarks to show that this improves performance?

This revision now requires changes to proceed.Jan 29 2015, 4:00 PM

I did measurements when implemented the patch and just retested once again using pmcstat instruction and BR_MISP_RETIRED.ALL_BRANCHES counters.
With the patch applied the number of instruction events is 1% less and number of mispredicted branch events is 5% less.

arybchik edited edge metadata.Feb 25 2015, 8:31 AM

arybchik edited subscribers, added: network; removed: Unknown Object (MLST).

gnn accepted this revision.Feb 26 2015, 4:23 PM

gnn edited edge metadata.

This revision is now accepted and ready to land.Feb 26 2015, 4:23 PM

Committed to head