Page MenuHomeFreeBSD

sfxge: Expect required init_state on data path and in periodic calls
ClosedPublic

Authored by arybchik on Jan 28 2015, 8:14 AM.
Tags
None
Referenced Files
F132587398: D1697.id3476.diff
Sat, Oct 18, 5:07 AM
Unknown Object (File)
Aug 23 2025, 4:53 PM
Unknown Object (File)
Jul 24 2025, 4:24 PM
Unknown Object (File)
Jun 27 2025, 9:19 AM
Unknown Object (File)
Jun 27 2025, 3:01 AM
Unknown Object (File)
Jun 17 2025, 8:08 PM
Unknown Object (File)
Jun 10 2025, 2:17 AM
Unknown Object (File)
May 13 2025, 3:12 AM
Subscribers

Details

Reviewers
gnn
Summary

Sponsored by: Solarflare Communications, Inc.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

arybchik retitled this revision from to sfxge: Expect required init_state on data path and in periodic calls.
arybchik updated this object.
arybchik edited the test plan for this revision. (Show Details)
arybchik added a reviewer: gnn.
arybchik added a subscriber: Unknown Object (MLST).
gnn requested changes to this revision.Jan 29 2015, 4:00 PM
gnn edited edge metadata.

__predict_false rarely, if ever, does the right thing. Have you run any benchmarks to show that this improves performance?

This revision now requires changes to proceed.Jan 29 2015, 4:00 PM

I did measurements when implemented the patch and just retested once again using pmcstat instruction and BR_MISP_RETIRED.ALL_BRANCHES counters.
With the patch applied the number of instruction events is 1% less and number of mispredicted branch events is 5% less.

arybchik edited subscribers, added: network; removed: Unknown Object (MLST).
gnn edited edge metadata.
This revision is now accepted and ready to land.Feb 26 2015, 4:23 PM