Page MenuHomeFreeBSD
Differential D16915

Long-overdue addition of my keys.
ClosedPublic
Actions

Authored by rpokala on Aug 27 2018, 3:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 8, 11:12 PM
Unknown Object (File)
Wed, Oct 8, 2:35 AM
Unknown Object (File)
Fri, Sep 26, 8:23 AM
Unknown Object (File)
Mon, Sep 22, 12:13 AM
Unknown Object (File)
Sat, Sep 20, 5:22 PM
Unknown Object (File)
Sat, Sep 20, 11:18 AM
Unknown Object (File)
Fri, Sep 19, 12:42 PM
Unknown Object (File)
Thu, Sep 18, 7:17 PM
View All 96 Files
Subscribers
zeising

Details

Reviewers
zeising
Commits
rD52189: I forgot to update the docs with my keys when I first got my commit bit.
Summary

I forgot to update the docs with my keys when I first got my commit bit.

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rpokala created this revision.Aug 27 2018, 3:33 AM
Harbormaster completed remote builds in B19198: Diff 47325.Aug 27 2018, 3:33 AM
rpokala updated this revision to Diff 47326.Aug 27 2018, 3:34 AM

Actually include the new key in the diff...

Harbormaster completed remote builds in B19199: Diff 47326.Aug 27 2018, 3:35 AM
zeising accepted this revision.Aug 27 2018, 9:38 PM
zeising added a subscriber: zeising.

Looks good apart from the news entry. I haven't actually tried to build it though.

share/xml/news.xml
1840 ↗(On Diff #47326)

Reverse cronological order, should come before november 1 in the file, on line 1831.

Side note, I think you can skip this, since it's so long ago.

This revision is now accepted and ready to land.Aug 27 2018, 9:38 PM
rpokala updated this revision to Diff 47376.Aug 28 2018, 7:37 AM

Re-order change to news.xml to be in reverse-chronological order.

This revision now requires review to proceed.Aug 28 2018, 7:37 AM
Harbormaster completed remote builds in B19234: Diff 47376.Aug 28 2018, 7:37 AM
rpokala marked an inline comment as done.Aug 28 2018, 7:42 AM

I went ahead and moved the news.xml change as you suggested; I'm including it there for posterity.

I also compared this change against the most recent change to contrib.committers.xml - rD52055 - and they're consistent.

zeising accepted this revision.Aug 28 2018, 8:11 AM

Looks good.

This revision is now accepted and ready to land.Aug 28 2018, 8:11 AM
Closed by commit rD52189: I forgot to update the docs with my keys when I first got my commit bit. (authored by rpokala). · Explain WhyAug 28 2018, 10:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
en_US.ISO8859-1/
articles/
contributors/
4 lines
share/
pgpkeys/
5 lines
1 line
43 lines
xml/
3 lines
9 lines

Diff 47415

View Options

head/en_US.ISO8859-1/articles/contributors/contrib.committers.xml

Loading...
View Options

head/share/pgpkeys/pgpkeys-developers.xml

Loading...
View Options

head/share/pgpkeys/pgpkeys.ent

Loading...
View Options

head/share/pgpkeys/rpokala.key

Loading...
View Options

head/share/xml/authors.ent

Loading...
View Options

head/share/xml/news.xml

Loading...