Page MenuHomeFreeBSD

Long-overdue addition of my keys.
ClosedPublic

Authored by rpokala on Aug 27 2018, 3:33 AM.

Details

Summary

I forgot to update the docs with my keys when I first got my commit bit.

Diff Detail

Repository
rD FreeBSD doc repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rpokala created this revision.Aug 27 2018, 3:33 AM
rpokala updated this revision to Diff 47326.Aug 27 2018, 3:34 AM

Actually include the new key in the diff...

zeising accepted this revision.Aug 27 2018, 9:38 PM
zeising added a subscriber: zeising.

Looks good apart from the news entry. I haven't actually tried to build it though.

share/xml/news.xml
1840 ↗(On Diff #47326)

Reverse cronological order, should come before november 1 in the file, on line 1831.

Side note, I think you can skip this, since it's so long ago.

This revision is now accepted and ready to land.Aug 27 2018, 9:38 PM
rpokala updated this revision to Diff 47376.Aug 28 2018, 7:37 AM

Re-order change to news.xml to be in reverse-chronological order.

This revision now requires review to proceed.Aug 28 2018, 7:37 AM
rpokala marked an inline comment as done.Aug 28 2018, 7:42 AM

I went ahead and moved the news.xml change as you suggested; I'm including it there for posterity.

I also compared this change against the most recent change to contrib.committers.xml - rD52055 - and they're consistent.

zeising accepted this revision.Aug 28 2018, 8:11 AM

Looks good.

This revision is now accepted and ready to land.Aug 28 2018, 8:11 AM
This revision was automatically updated to reflect the committed changes.