Page MenuHomeFreeBSD

porters-handbook: Add more example in the advanced pkg-plist
ClosedPublic

Authored by dbaio on Aug 5 2018, 9:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 17, 12:20 PM
Unknown Object (File)
Sun, Dec 29, 6:24 AM
Unknown Object (File)
Sep 18 2024, 11:40 AM
Unknown Object (File)
Sep 9 2024, 2:35 AM
Unknown Object (File)
Sep 8 2024, 11:34 PM
Unknown Object (File)
Sep 8 2024, 10:26 PM
Unknown Object (File)
Sep 5 2024, 2:10 AM
Unknown Object (File)
Sep 5 2024, 12:41 AM
Subscribers
None

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Not sure why this is needed. Options generated PLIST_SUB entries always go at the start of the line.

In D16598#352729, @mat wrote:

Not sure why this is needed. Options generated PLIST_SUB entries always go at the start of the line.

I thought about this tip because of this:

tomcat85-pkgplist
tomcat9-pkgplist

And to be honest, I was in doubt when I saw @sample %%OPTION%% in the port and I needed to test.

I know this can be a one time issue only, but IMHO it won't cause any harm.

It is only an issue if you do not test, right. All PLIST option helpers add @comment to comment the line out, so it does not make much sense in the middle of the line. It shows a real lack of understanding of what is going on.

I feel this is the wrong place for this, as it is not specific to @sample.

Is this location better?

See here

I found another port with this issue.
/net-mgmt/icinga-core/pkg-plist:

@sample %%IDOUTILS%%%%ETCDIR%%/ido2db.cfg.sample
@sample %%IDOUTILS%%%%ETCDIR%%/idomod.cfg.sample
@sample %%IDOUTILS%%%%ETCDIR%%/modules/idoutils.cfg.sample
This revision was not accepted when it landed; it landed in state Needs Review.Aug 13 2018, 11:40 AM
This revision was automatically updated to reflect the committed changes.

Moved it out of a specific section, and reworded a bit, thanks for the patch.