Details
Details
- Reviewers
mat - Commits
- rD52123: Add a warning about the order of plist helpers/keywords.
Diff Detail
Diff Detail
- Repository
- rD FreeBSD doc repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Not sure why this is needed. Options generated PLIST_SUB entries always go at the start of the line.
Comment Actions
I thought about this tip because of this:
tomcat85-pkgplist
tomcat9-pkgplist
And to be honest, I was in doubt when I saw @sample %%OPTION%% in the port and I needed to test.
I know this can be a one time issue only, but IMHO it won't cause any harm.
Comment Actions
It is only an issue if you do not test, right. All PLIST option helpers add @comment to comment the line out, so it does not make much sense in the middle of the line. It shows a real lack of understanding of what is going on.
I feel this is the wrong place for this, as it is not specific to @sample.
Comment Actions
Is this location better?
I found another port with this issue.
/net-mgmt/icinga-core/pkg-plist:
@sample %%IDOUTILS%%%%ETCDIR%%/ido2db.cfg.sample @sample %%IDOUTILS%%%%ETCDIR%%/idomod.cfg.sample @sample %%IDOUTILS%%%%ETCDIR%%/modules/idoutils.cfg.sample