Differential D1639

Teach pciconf how to dump out SR-IOV capability
ClosedPublic
Actions

Authored by rstone on Jan 24 2015, 10:39 PM.

Details

Reviewers

jhb

Commits

rS279466: Teach pciconf how to dump out SR-IOV capability

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rstone updated this revision to Diff 3392.Jan 24 2015, 10:39 PM

rstone retitled this revision from to Teach pciconf how to dump out SR-IOV capability.

rstone edited the test plan for this revision. (Show Details)

rstone added a reviewer: jhb.

I think this looks fine. Do you have some sample output?

This revision is now accepted and ready to land.Jan 25 2015, 8:25 PM

jhb added inline comments.Jan 25 2015, 8:32 PM

usr.sbin/pciconf/pciconf.h
41	Perhaps avoid the extra line here and just sort 'print_bar' into the existing list of prototypes?

Sample output:

ecap 0010[160] = SR-IOV 1 IOV enabled, Memory Space enabled, ARI enabled
                 4 VFs configured out of 128 supported
                 First VF RID Offset 0x0010, VF RID Stride 0x0001
                 VF Device ID 0x154c
                 Page Sizes: 4096 (enabled), 8192, 65536, 262144, 1048576, 4194304

Thanks. I would suggest including that in a followup reply to the commit itself.

rstone closed this revision.Feb 20 2015, 1:03 AM