Page MenuHomeFreeBSD
Differential D16341

lang/ruby2[4|5]: Use RUBY_DLDFLAGS right way, get rid of unescaped macro
ClosedPublic
Actions

Authored by fluffy on Jul 19 2018, 7:16 AM.
Tags
Referenced Files
F102204793: D16341.id45516.diff
Fri, Nov 8, 10:45 PM
Unknown Object (File)
Thu, Nov 7, 4:53 AM
Unknown Object (File)
Fri, Nov 1, 2:15 AM
Unknown Object (File)
Tue, Oct 22, 1:32 PM
Unknown Object (File)
Sat, Oct 19, 2:32 AM
Unknown Object (File)
Oct 6 2024, 3:59 PM
Unknown Object (File)
Oct 6 2024, 8:30 AM
Unknown Object (File)
Oct 6 2024, 4:02 AM
View All 50 Files
Subscribers
mat
miwi
Ruby

Details

Reviewers
miwi
Group Reviewers
Ruby
portmgr
O5: Ports Framework
Commits
rP475488: MFH: r475483
rP475483: lang/ruby2[4|5]: Use internal RUBY_DLDFLAGS right way, get rid of unescaped…
Summary

lang/ruby2[4|5]: Use internal RUBY_DLDFLAGS right way, get rid of unescaped macro '$@' in the pkg-config template

lang/ruby23 is already fixed same way, port it to newer releases

By the way, this unbreak ninja builds with any port, relied on libruby.so

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fluffy created this revision.Jul 19 2018, 7:16 AM
Herald added a reviewer: portmgr. · View Herald TranscriptJul 19 2018, 7:16 AM
Herald added a subscriber: mat. · View Herald Transcript
miwi added a subscriber: miwi.Jul 19 2018, 7:18 AM
miwi added a comment.Jul 19 2018, 3:48 PM

This makes sense, but I think we should request an exp-run.

fluffy added a comment.Jul 21 2018, 2:09 AM
In D16341#346995, @miwi wrote:

This makes sense, but I think we should request an exp-run.

created
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229898

fluffy added a comment.EditedJul 25 2018, 3:28 AM

Exp-run looks fine, please approve
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229898

miwi accepted this revision.Jul 27 2018, 6:13 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 28 2018, 2:53 AM
Closed by commit rP475483: lang/ruby2[4|5]: Use internal RUBY_DLDFLAGS right way, get rid of unescaped… (authored by fluffy). · Explain Why
This revision was automatically updated to reflect the committed changes.
Owners added a reviewer: O5: Ports Framework.Jul 28 2018, 2:53 AM
fluffy mentioned this in rP475483: lang/ruby2[4|5]: Use internal RUBY_DLDFLAGS right way, get rid of unescaped….Jul 28 2018, 2:53 AM
fluffy mentioned this in rP475488: MFH: r475483.Jul 28 2018, 3:37 AM

Revision Contents
Changeset List

PathSizePackages
head/
Mk/
4 linesO5: Ports Framework
lang/
ruby24/
files/
19 lines
ruby25/
files/
19 lines

Diff 45936

View Options

head/Mk/bsd.ruby.mk

Loading...
View Options

head/lang/ruby24/files/patch-configure.in

Loading...
View Options

head/lang/ruby25/files/patch-configure.ac

Loading...