Page MenuHomeFreeBSD

net/tigervnc: update 1.8.0 -> 1.9.0 While here, * Adjust USE_XROG
ClosedPublic

Authored by meta on Jul 19 2018, 3:03 AM.

Details

Summary

Approved by: ? (mentor)
Relnotes: https://github.com/TigerVNC/tigervnc/releases/tag/v1.9.0
#Differential Revision:

I'm planning to separate the port into tigervnc-server and tigervnc-viewer
but just updating at this time.

Test Plan
  • no new warnings by portlint -AC
  • poudriere testbuild finished successfully @112amd64
  • confirmed it actually works

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

meta created this revision.Jul 19 2018, 3:03 AM
meta updated this revision to Diff 45512.Jul 19 2018, 3:13 AM

regenerate patches

meta updated this revision to Diff 45513.Jul 19 2018, 3:14 AM

remove other port's diff

meta updated this revision to Diff 45574.Jul 20 2018, 2:37 AM

remove tridiavnc from CONFLICTS since the port no longer exists

meta updated this revision to Diff 45575.Jul 20 2018, 2:38 AM

remove tridiavnc from CONFLICTS

pi accepted this revision.Jul 20 2018, 7:19 AM

I've test-build, and it looks good. Two small things:

  • The USES-line is almost 80chars long and already has a \ to the following line. Can you move one more element to the next line ?
  • The IGNORE for -devel needs to higher up in the Makefile, see portlint's complaints
This revision is now accepted and ready to land.Jul 20 2018, 7:19 AM
meta updated this revision to Diff 45587.Jul 20 2018, 8:07 AM
  • bring IGNORE line earlier
  • more one more USES element to the next line
This revision now requires review to proceed.Jul 20 2018, 8:07 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 20 2018, 8:17 AM
This revision was automatically updated to reflect the committed changes.
meta added a comment.Jul 20 2018, 8:46 AM

Committed, thanks for your review.