Page MenuHomeFreeBSD

NEW PORT: net-mgmt/postfix_exporter: Postfix Exporter for Prometheus
Needs ReviewPublic

Authored by fabian.freyer_physik.tu-berlin.de on Jul 13 2018, 3:03 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

postfix_exporter is a prometheus exporter for postfix.

See PR 229756

Test Plan
  • portlint
  • poudriere testport

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

mat added inline comments.Jul 13 2018, 3:08 PM
net-mgmt/postfix_exporter/Makefile
7

None of the file have a generic name, please remove.

net-mgmt/postfix_exporter/Makefile
7

I just went along with https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-distfiles.html:

Do not let the port clutter /usr/ports/distfiles. If the port requires a lot of files to be fetched, [...] set DIST_SUBDIR to the name of the port

However, I'm not sure how many files is "a lot". I'll remove this then.

mat added inline comments.Jul 13 2018, 6:52 PM
net-mgmt/postfix_exporter/Makefile
7

Mmmm, I think this could probably go.

The idea is that github generated files are named consistenly, so that if more than one port uses the same project/commit, they can use the same distribution file.

net-mgmt/postfix_exporter/Makefile
18

I guess here and below, I should use the actutal commit hash instead of master?

mat added inline comments.Jul 14 2018, 12:41 PM
net-mgmt/postfix_exporter/Makefile
18

Yes, it should. There is a test for the default distfile, but it got forgotten in the GH_TUPLE, I'll look into expanding it.

updated GH_TUPLE to include commit hashes instead of master

linimon retitled this revision from NEW PORT: net-mgmt/postfix_exporter to NEW PORT: net-mgmt/postfix_exporter: Postfix Exporter for Prometheus.Aug 2 2018, 10:03 PM
dmgk added a subscriber: dmgk.Tue, Sep 17, 9:41 PM
dmgk added inline comments.
net-mgmt/postfix_exporter/Makefile
15

If GH_TUPLE entries would place packages in vendor, the post-extract below can be removed:

GH_TUPLE+=      prometheus:client_golang:v0.8.0:prometheus_client/vendor/github.com/prometheus/client_golang
GH_TUPLE+=      golang:protobuf:v1.1.0:protobuf/vendor/github.com/golang/protobuf
GH_TUPLE+=      beorn7:perks:3a771d992973f24aa725d07868b467d1ddfceafb:quantile/vendor/github.com/beorn7/perks
GH_TUPLE+=      prometheus:client_model:5c3871d89910bfb32f5fcab2aa4b9ec68e65a99f:prometheus_client_model/vendor/github.com/prometheus/client_mod
el
GH_TUPLE+=      prometheus:common:7600349dcfe1abd18d72d3a1770870d9800a7801:prometheus_common/vendor/github.com/prometheus/common
GH_TUPLE+=      prometheus:procfs:ae68e2d4c00fed4943b5f6698d504a5fe083da8a:prometheus_procfs/vendor/github.com/prometheus/procfs
GH_TUPLE+=      matttproud:golang_protobuf_extensions:v1.0.1:pbutil/vendor/github.com/matttproud/golang_protobuf_extensions
27

This is the default (GO_TARGET defaults to GO_PKGNAME)

31

This is not needed if dependencies go to vendor.

37

do-build can be replaced with just

GO_BUILDFLAGS=  -tags nosystemd