Page MenuHomeFreeBSD

Fix serialization of empty sub-nvlists
AbandonedPublic

Authored by rstone on Jan 23 2015, 1:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 5 2024, 6:28 AM
Unknown Object (File)
Apr 25 2023, 9:39 AM
Unknown Object (File)
Apr 7 2023, 4:28 PM
Unknown Object (File)
Dec 20 2022, 11:20 AM
Unknown Object (File)
Apr 12 2017, 9:57 PM
Unknown Object (File)
Apr 11 2017, 7:17 AM
Unknown Object (File)
Apr 7 2017, 7:12 PM
Unknown Object (File)
Nov 15 2016, 12:37 PM
Subscribers
None

Details

Reviewers
pjd

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rstone retitled this revision from to Fix serialization of empty sub-nvlists.
rstone edited the test plan for this revision. (Show Details)
rstone added inline comments.
sys/kern/subr_nvlist.c
367

If the sub-nvlist is empty, then nvp will be NULL here. Running "continue;" here will cause the while loop to terminate prematurely without finishing the serialization of our parent. Fixing this with a goto is quite ugly but I couldn't see a very good way to get around it

563

oops. Will fix unnecessary braces

Update unit test to test serializing an empty nvlist

Already fixed in r277925