Page MenuHomeFreeBSD

Mk/Uses/scons.mk: restore ability to respect CFLAGS and LDFLAGS by default
ClosedPublic

Authored by jbeich on Jan 22 2015, 6:26 PM.

Details

Summary

Pass CFLAGS and LDFLAGS by default to scons build, again

This fixes rP329140 regression.

PR: 193434

Test Plan

poudriere logs are attached to the bug. A total of 48 consumers.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

jbeich updated this revision to Diff 3330.Jan 22 2015, 6:26 PM
jbeich retitled this revision from to Mk/Uses/scons.mk: restore ability to respect CFLAGS and LDFLAGS by default.
jbeich updated this object.
jbeich edited the test plan for this revision. (Show Details)
jbeich added reviewers: portmgr, Python, bapt.
bapt accepted this revision.Jan 22 2015, 6:28 PM
bapt edited edge metadata.

Thanks for fixing my breakages :) (no need to wait a review from python@)

This revision is now accepted and ready to land.Jan 22 2015, 6:28 PM

Sorry, I've mistyped the regression commit. rP355494 was more simple

MAKE_ENV+=  CCFLAGS="${CFLAGS}"  LINKFLAGS="${LDFLAGS}"

became

MAKE_ARGS+= CCFLAGS="${CCFLAGS}" LINKFLAGS="${LINKFLAGS}"
jbeich closed this revision.Jan 22 2015, 6:52 PM
jbeich updated this revision to Diff 3331.

Closed by commit rP377692 (authored by @jbeich).