Page MenuHomeFreeBSD

Mk/Uses/scons.mk: restore ability to respect CFLAGS and LDFLAGS by default
ClosedPublic

Authored by jbeich on Jan 22 2015, 6:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 3:52 PM
Unknown Object (File)
Mar 15 2024, 6:49 PM
Unknown Object (File)
Mar 15 2024, 6:49 PM
Unknown Object (File)
Mar 15 2024, 6:49 PM
Unknown Object (File)
Mar 15 2024, 6:37 PM
Unknown Object (File)
Feb 24 2024, 12:19 AM
Unknown Object (File)
Feb 23 2024, 8:21 PM
Unknown Object (File)
Feb 22 2024, 7:04 PM
Subscribers
None

Details

Summary

Pass CFLAGS and LDFLAGS by default to scons build, again

This fixes rP329140 regression.

PR: 193434

Test Plan

poudriere logs are attached to the bug. A total of 48 consumers.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jbeich retitled this revision from to Mk/Uses/scons.mk: restore ability to respect CFLAGS and LDFLAGS by default.
jbeich updated this object.
jbeich edited the test plan for this revision. (Show Details)
jbeich added reviewers: portmgr, Python, bapt.
bapt edited edge metadata.

Thanks for fixing my breakages :) (no need to wait a review from python@)

This revision is now accepted and ready to land.Jan 22 2015, 6:28 PM

Sorry, I've mistyped the regression commit. rP355494 was more simple

MAKE_ENV+=  CCFLAGS="${CFLAGS}"  LINKFLAGS="${LDFLAGS}"

became

MAKE_ARGS+= CCFLAGS="${CCFLAGS}" LINKFLAGS="${LINKFLAGS}"
jbeich updated this revision to Diff 3331.

Closed by commit rP377692 (authored by @jbeich).