scons.mk: restore ability to respect CFLAGS and LDFLAGS by default
ClosedPublic
Actions

Authored by jbeich on Jan 22 2015, 6:26 PM.

Tags

None

Referenced Files

	F132421996: D1602.id.diff
	Thu, Oct 16, 7:27 PM

	Unknown Object (File)
	Sat, Oct 11, 7:17 AM

	Unknown Object (File)
	Fri, Oct 3, 12:01 PM

	Unknown Object (File)
	Fri, Oct 3, 4:35 AM

	Unknown Object (File)
	Fri, Oct 3, 2:05 AM

	Unknown Object (File)
	Wed, Oct 1, 8:34 AM

	Unknown Object (File)
	Mon, Sep 29, 10:03 PM

	Unknown Object (File)
	Mon, Sep 29, 2:54 AM

View All Files

Subscribers

None

Details

Reviewers

bapt

Group Reviewers

portmgr
Python

Commits

rP377692: Pass CFLAGS and LDFLAGS by default to scons build, again

Summary

Pass CFLAGS and LDFLAGS by default to scons build, again

This fixes rP329140 regression.

PR: 193434

Test Plan

poudriere logs are attached to the bug. A total of 48 consumers.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

jbeich updated this revision to Diff 3330.Jan 22 2015, 6:26 PM

jbeich retitled this revision from to Mk/Uses/scons.mk: restore ability to respect CFLAGS and LDFLAGS by default.

jbeich updated this object.

jbeich edited the test plan for this revision. (Show Details)

jbeich added reviewers: portmgr, Python, bapt.

Herald edited edge metadata. · View Herald TranscriptJan 22 2015, 6:26 PM

Thanks for fixing my breakages :) (no need to wait a review from python@)

This revision is now accepted and ready to land.Jan 22 2015, 6:28 PM

Sorry, I've mistyped the regression commit. rP355494 was more simple

MAKE_ENV+=  CCFLAGS="${CFLAGS}"  LINKFLAGS="${LDFLAGS}"

became

MAKE_ARGS+= CCFLAGS="${CCFLAGS}" LINKFLAGS="${LINKFLAGS}"

Closed by commit rP377692 (authored by @jbeich).

Revision Contents
Changeset List

Path

Size

Packages

head/

Mk/

Uses/

scons.mk

2 lines

O5: Ports Framework

audio/

csound/

Makefile

1 line

Diff 3331

View Options

head/Mk/Uses/scons.mk