Page MenuHomeFreeBSD

Little clean-up on php.mk
ClosedPublic

Authored by pizzamig on Jun 14 2018, 4:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 20, 2:37 AM
Unknown Object (File)
Mar 4 2025, 3:26 PM
Unknown Object (File)
Feb 24 2025, 11:01 PM
Unknown Object (File)
Feb 22 2025, 11:17 PM
Unknown Object (File)
Feb 21 2025, 6:10 AM
Unknown Object (File)
Jan 30 2025, 1:46 PM
Unknown Object (File)
Jan 26 2025, 4:07 AM
Unknown Object (File)
Dec 28 2024, 3:25 PM
Subscribers
None

Details

Summary

php.mk is still referring to some not-existant extensions, like ncurses, sqlite, oci8.
Moreover, spl is not built as extension (the port doesn't exist) and is treated like pcre.
Converted if ${PHP_VER} == 70 || ${PHP_VER} == 71 || ${PHP_VER} == 72 as if ${PHP_VER} >= 70
improving uniformity

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

spl is treated exactly as pcre, they are two always-on extensions. Why would you remove one and not the other? Removing it would break all ports that explicitly depends on it (USE_PHP=spl). Even if it's currently enabled by default, its explicit dependency allows for newer php versions to have it as a module without any change to other ports.

Put spl back to _USE_PHP_ALL, as it correctly belongs.
Sorry for the poor word choice, I wanted only remove the DEPENDS line
that refer to a package that doesn't exist.

This revision is now accepted and ready to land.Jun 15 2018, 12:55 PM
This revision was automatically updated to reflect the committed changes.