Page MenuHomeFreeBSD

Little clean-up on php.mk
ClosedPublic

Authored by pizzamig on Jun 14 2018, 4:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 4, 3:53 AM
Unknown Object (File)
Dec 22 2023, 11:02 PM
Unknown Object (File)
Dec 20 2023, 1:29 PM
Unknown Object (File)
Nov 22 2023, 8:36 AM
Unknown Object (File)
Nov 7 2023, 11:30 AM
Unknown Object (File)
Nov 7 2023, 2:30 AM
Unknown Object (File)
Oct 17 2023, 6:15 PM
Unknown Object (File)
Oct 17 2023, 6:15 PM
Subscribers
None

Details

Reviewers
ale
tz
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Commits
rP472460: Mk/Uses/php.mk: small clean-up
Summary

php.mk is still referring to some not-existant extensions, like ncurses, sqlite, oci8.
Moreover, spl is not built as extension (the port doesn't exist) and is treated like pcre.
Converted if ${PHP_VER} == 70 || ${PHP_VER} == 71 || ${PHP_VER} == 72 as if ${PHP_VER} >= 70
improving uniformity

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 17298
Build 17135: arc lint + arc unit

Event Timeline

spl is treated exactly as pcre, they are two always-on extensions. Why would you remove one and not the other? Removing it would break all ports that explicitly depends on it (USE_PHP=spl). Even if it's currently enabled by default, its explicit dependency allows for newer php versions to have it as a module without any change to other ports.

Put spl back to _USE_PHP_ALL, as it correctly belongs.
Sorry for the poor word choice, I wanted only remove the DEPENDS line
that refer to a package that doesn't exist.

This revision is now accepted and ready to land.Jun 15 2018, 12:55 PM
This revision was automatically updated to reflect the committed changes.