php.mk is still referring to some not-existant extensions, like ncurses, sqlite, oci8.
Moreover, spl is not built as extension (the port doesn't exist) and is treated like pcre.
Converted if ${PHP_VER} == 70 || ${PHP_VER} == 71 || ${PHP_VER} == 72 as if ${PHP_VER} >= 70
improving uniformity
Details
Details
- Reviewers
ale tz - Group Reviewers
O5: Ports Framework (Owns No Changed Paths) portmgr - Commits
- rP472460: Mk/Uses/php.mk: small clean-up
Diff Detail
Diff Detail
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 17298 Build 17135: arc lint + arc unit
Event Timeline
Comment Actions
spl is treated exactly as pcre, they are two always-on extensions. Why would you remove one and not the other? Removing it would break all ports that explicitly depends on it (USE_PHP=spl). Even if it's currently enabled by default, its explicit dependency allows for newer php versions to have it as a module without any change to other ports.
Comment Actions
Put spl back to _USE_PHP_ALL, as it correctly belongs.
Sorry for the poor word choice, I wanted only remove the DEPENDS line
that refer to a package that doesn't exist.